feat(agent): add counterfactual reasons to decision snapshots - #361
Merged
JSONbored merged 6 commits intoJun 4, 2026
Merged
Conversation
JSONbored
approved these changes
Jun 4, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@bitloi this is ready from this pass.
A few notes:
- Adding structured counterfactual reasons to repo decisions and scoped snapshots improves explainability without exposing raw private scoring context.
- The implementation keeps facts, assumptions, and public summaries separated.
- The focused decision-pack/orchestrator tests cover the new behavior, and CI validate is green.
No code changes are requested from this review pass.
JSONbored
self-requested a review
June 4, 2026 19:06
JSONbored
approved these changes
Jun 4, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@bitloi this remains merge-ready.
A few notes:
- The counterfactual reason additions are scoped to the decision snapshot behavior.
- The current branch is locally merge-clean against main.
- No code changes requested.
Validation expected:
- Keep the current green CI run after any required branch update.
Closed
12 tasks
24 tasks
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #284
counterfactualReasonsto repo decisions and decision actions so snapshots can explain why obvious alternatives were rejected.rejectedAlternativesper selected repo.Scope
CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally; global coverage stays at or above 97% for lines, statements, functions, and branches (aim for 98%+ branch coverage locally so CI variance does not fail near the threshold)npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:coverage/npm run validatewas attempted locally, but this shell is on Node 24 while.nvmrcrequires Node 22. The unrelatedtest/unit/local-scorer-adapter.test.tsexternal-command fixtures fail locally withscorer_failedfallback results before coverage can complete. Focused feat(agent): add counterfactual reasons to decision snapshots #284 tests pass withnpx vitest run test/unit/decision-pack.test.ts test/unit/agent-orchestrator.test.ts(59 tests), and CI should run the full Node 22 gate.npx vitest run --coverage test/unit/decision-pack.test.ts test/unit/agent-orchestrator.test.ts; the tests pass, but the repo-wide 97% global threshold fails as expected for a partial suite.validatepassed on this PR after submission.Safety
npm run ui:openapi:checkpassed.Notes
factsfromassumptionsand include sanitizedpublicSummarytext for public-safe downstream summaries.