fix(signals): classify grpc-node JS/TS protobuf stubs as generated - #3581
Conversation
Recognize grpc-node *_pb.js/ts, *_grpc_pb.js/ts, and *_pb.d.ts declaration stubs in isGeneratedFile with classifyChangedFile hot-path coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3581 +/- ##
=======================================
Coverage 93.15% 93.15%
=======================================
Files 311 311
Lines 31702 31702
Branches 11579 11579
=======================================
Hits 29533 29533
Misses 1517 1517
Partials 652 652
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 17:53:19 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 4 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
Extend
isGeneratedFileto recognize grpc-node message/service stubs (*_pb.js,*_pb.ts,*_grpc_pb.js,*_grpc_pb.ts) and TypeScript declaration stubs (*_pb.d.ts,*_grpc_pb.d.ts), matching the existing.pb.js/.pb.tsdot-form protoc coverage. Includes directisGeneratedFile/classifyChangedFileassertions and hand-authored negative cases.Fixes #2279
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — signals-only change with no visible UI.
Notes
Incremental maintenance parity for path-matcher slop signals supporting the engine extraction tracked in #2279. Does not complete the full slop-engine deliverable.
Made with Cursor