Skip to content

feat(engine): add hasPlanCompletedSteps and document packages - #3540

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/plan-completed-steps-2298
Jul 5, 2026
Merged

feat(engine): add hasPlanCompletedSteps and document packages#3540
JSONbored merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/plan-completed-steps-2298

Conversation

@kiannidev

Copy link
Copy Markdown
Contributor

Closes #2298

Summary

Conflict avoidance

Touches only packages/gittensory-engine/src/plan-completed.ts (new), one export line in index.ts, one engine README bullet, test/unit/plan-completed.test.ts (new), and two root README table rows. No overlap with open PRs #3513, #3523, #3535, #3539.

Test plan

  • COVERAGE_NO_THRESHOLDS=1 npx vitest run test/unit/plan-completed.test.ts --coverage
  • npx diff-cover coverage/lcov.info --compare-branch=main --fail-under=99 → 100%
  • npm run build --workspace @jsonbored/gittensory-engine && npm run build:miner

Made with Cursor

Add the partial-progress plan DAG predicate, update the engine README
export list, and link engine/miner packages from the root README.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev
kiannidev requested a review from JSONbored as a code owner July 5, 2026 16:28
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.10%. Comparing base (5bdc8bc) to head (c6ea6e1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3540   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files         302      303    +1     
  Lines       31504    31505    +1     
  Branches    11504    11504           
=======================================
+ Hits        29333    29334    +1     
  Misses       1517     1517           
  Partials      654      654           
Files with missing lines Coverage Δ
packages/gittensory-engine/src/plan-completed.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 16:33:37 UTC

5 files · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
Adds `hasPlanCompletedSteps` as a pure `Array.prototype.some` predicate over `PlanDag.steps`, following the identical pattern already established by `hasPlanFailedSteps`, `hasPlanPendingSteps`, `hasPlanRunningSteps`, and `hasPlanSkippedSteps`. The implementation, barrel export, and all four test cases (empty plan, no-match, at-least-one-match, barrel export) are correct. README additions are accurate and the Surfaces table entries are well-formed.

Nits — 5 non-blocking
  • test/unit/plan-completed.test.ts: the `step()` factory already defaults `status` to `"pending"`, so the explicit `status: "pending"` overrides in the false-path test cases are redundant — drop them for clarity.
  • test/unit/plan-completed.test.ts: the false-path test only exercises `pending` and `running`; adding a `failed` or `skipped` step to that case would document that ALL non-`"completed"` statuses return false, consistent with how sibling tests are written.
  • README.md line for Miner package has trailing spaces before the closing `|` (`runtime |`) — nit, but inconsistent with the rest of the table.
  • packages/gittensory-engine/src/index.ts: `hasPlanCompletedSteps` is appended after the other four `hasPlan*` exports rather than placed alongside them alphabetically; the sibling exports are ordered `Failed → Pending → Running → Skipped → Completed` — consider inserting it as `Completed → Failed → Pending → Running → Skipped` or leaving it last with a comment if intentional (the current position just breaks the alphabetical run).
  • test/unit/plan-completed.test.ts: consolidate the false-path test into a single parametrized `it.each` across all non-`completed` statuses (`pending`, `running`, `failed`, `skipped`) — it matches how the sibling test files (e.g. `plan-failure.test.ts`) are structured and locks in the exhaustive false-path contract in one place.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2298
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 1433 registered-repo PR(s), 732 merged, 48 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 1433 PR(s), 48 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: TypeScript, MDX, C++, HTML, Rust
  • Official Gittensor activity: 1433 PR(s), 48 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@JSONbored
JSONbored merged commit 03f8926 into JSONbored:main Jul 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. manual-review Gittensor contributor context

Development

Successfully merging this pull request may close these issues.

docs(miner-foundation): gittensory-miner and gittensory-engine README + package docs

2 participants