feat(review): add review.tone public-safe voice brief knob (#2044)

[RealDiligent]

Summary

• Add review.tone — bounded public-safe voice brief complementing review.profile (feat(config): add review.tone public-safe free-text brief knob #2044).

Closes #2044
Part of #1959. Supersedes closed #3506 (rebased on main).

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-05 14:50:48 UTC}

5 files · 1 AI reviewer · no blockers · readiness 62/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This adds `review.tone` as a parsed public-safe manifest field, round-trips it through `reviewConfigToJson`, resolves it with the existing prompt override bundle, and folds it into the AI review instruction slot at publish time. The visible wiring is coherent for the manifest path and the PR is linked to #2044; I do not see a reachable correctness break in the changed code. The main issue is a small contract mismatch in the new compose helper: it trims `review.instructions` even when no tone is present, which is harmless on the current parsed path but contradicts the byte-identical wording.

Nits — 6 non-blocking

• src/signals/focus-manifest.ts:1881: nit: `composeManifestReviewInstructions` says null or empty tone leaves instructions byte-identical, but it returns `instructions?.trim()` rather than the original string when tone is absent.
• src/signals/focus-manifest.ts:1884: nit: the hard-coded section label is now part of the reviewer prompt contract, so consider extracting it to a named constant near the review-profile prompt constants if this file already centralizes prompt wording.
• .gittensory.yml.example:578: nit: the example documents the knob, but the diff does not show any generated config/schema reference update; confirm there is no generated manifest schema or public config reference that also needs `review.tone`.
• src/signals/focus-manifest.ts:1881: Change the no-tone branch to return `instructions` directly, or update the comment/tests to make the trimming behavior explicit.
• src/signals/focus-manifest.ts:1884: Add a focused assertion that whitespace-only `tone` behaves exactly like an absent tone and preserves the current instruction value.
• Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#2044, #3506
Related work	⚠️ 3 scoped overlaps	Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope	❌ 8/20	High review scope from cached public metadata (2 linked issues).
Validation posture	❌ 5/25	Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload	✅ 10/10	Author activity: 163 registered-repo PR(s), 28 merged, 0 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	RealDiligent; Gittensor profile; 163 PR(s), 0 issue(s).
Gate result	✅ Passing	No configured blocker found.

Review context

• Author: RealDiligent
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: not available
• Official Gittensor activity: 163 PR(s), 0 issue(s).
• Related work: Titles/paths share 5 meaningful terms. (issue #1680, issue #1681)
• Related work: Titles/paths share 5 meaningful terms. (issue #1683, issue #1681)
• Related work: Titles/paths share 7 meaningful terms. (issue #2044, issue #2046)
• Additional title-only matches omitted; title-only overlap does not block.

Contributor next steps

• Review top overlaps.
• Add a concise scope and risk note.
• Await review-lane availability.
• Refresh registry data or choose a registered active repo.
• Check active issues and PRs before submitting.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.09%. Comparing base (6177270) to head (85a7f04).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3507   +/-   ##
=======================================
  Coverage   93.08%   93.09%           
=======================================
  Files         300      300           
  Lines       31416    31424    +8     
  Branches    11468    11473    +5     
=======================================
+ Hits        29244    29253    +9     
  Misses       1517     1517           
+ Partials      655      654    -1     

Files with missing lines	Coverage Δ
src/queue/processors.ts	93.53% <ø> (ø)
src/signals/focus-manifest.ts	98.92% <100.00%> (+0.10%)	⬆️

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Gittensory approves — the gate is satisfied and CI is green.