Skip to content

feat(review): add review.path_filters include/negation globs (#2043) - #3494

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
RealDiligent:feat/review-path-filters-2043
Jul 5, 2026
Merged

feat(review): add review.path_filters include/negation globs (#2043)#3494
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
RealDiligent:feat/review-path-filters-2043

Conversation

@RealDiligent

Copy link
Copy Markdown
Contributor

Summary

  • Adds review.path_filters to .gittensory.yml: include globs plus leading-! negation entries that positively scope advisory AI review file selection after review.exclude_paths.
  • Wires parsing, round-trip serialization, filterReviewFilesForAi, processor threading, and AI review cache fingerprinting.
  • Block mode still reviews the full diff (same semantics as exclude_paths); gate/slop/secret-scan are unaffected.

Closes #2043

Test plan

  • npm run typecheck
  • vitest run test/unit/focus-manifest.test.ts test/unit/ai-review-cache-input.test.ts test/unit/ai-review-advisory.test.ts
  • CI + codecov patch coverage on changed files

…ed#2043)

Let maintainers positively scope advisory AI review file selection after exclude_paths, with cache fingerprinting and block-mode bypass matching exclude_paths semantics.

Co-authored-by: Cursor <cursoragent@cursor.com>
@RealDiligent
RealDiligent requested a review from JSONbored as a code owner July 5, 2026 11:31
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 11:36:47 UTC

10 files · 1 AI reviewer · no blockers · readiness 62/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This change cleanly adds `review.path_filters` as a manifest-only advisory AI review selector, threads it into prompt override resolution, advisory file filtering, and cache fingerprinting, while preserving block-mode full-diff review semantics. The implementation applies filters after `exclude_paths`, handles include and leading-`!` subtraction consistently, and the tests cover parsing, round-trip serialization, cache invalidation, and the advisory-vs-block distinction. I do not see a reachable correctness defect in the visible diff.

Nits — 5 non-blocking
  • nit: `test/unit/ai-review-cache.test.ts:27` has the new `excludePaths` / `pathFilters` entries over-indented relative to the rest of `baseFingerprintInput`, which passed tooling but makes this fixture look accidentally nested.
  • nit: `test/unit/ai-review-advisory.test.ts:520` verifies advisory include filtering after `exclude_paths`, but the processor-facing test does not exercise a leading-`!` path filter in the prompt path; the helper test covers the logic, but an end-to-end advisory prompt assertion would make the wiring harder to regress.
  • In `test/unit/ai-review-cache.test.ts:27`, align `excludePaths` and `pathFilters` with the surrounding object keys so future fixture edits do not have to visually parse whether the shape changed.
  • In `test/unit/ai-review-advisory.test.ts:520`, add `!src/generated/**` to `reviewPathFilters` and leave `reviewExcludePaths` focused on a separate file type, or tell me why the helper-level negation coverage is enough for this wiring path.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2043
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 146 registered-repo PR(s), 19 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor RealDiligent; Gittensor profile; 146 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: RealDiligent
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: JavaScript, Ruby, Svelte, TypeScript, Cuda, Markdown
  • Official Gittensor activity: 146 PR(s), 0 issue(s).
  • Related work: Titles/paths share 5 meaningful terms. (issue #1680, issue #1681)
  • Related work: Titles/paths share 5 meaningful terms. (issue #1683, issue #1681)
  • Related work: Titles/paths share 8 meaningful terms. (issue #2040, issue #2060)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.06%. Comparing base (458f83e) to head (7687590).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3494   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files         300      300           
  Lines       31298    31336   +38     
  Branches    11421    11435   +14     
=======================================
+ Hits        29126    29164   +38     
  Misses       1517     1517           
  Partials      655      655           
Files with missing lines Coverage Δ
src/queue/processors.ts 93.48% <100.00%> (ø)
src/review/ai-review-cache-input.ts 100.00% <ø> (ø)
src/signals/focus-manifest.ts 98.74% <100.00%> (+0.05%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 850c767 into JSONbored:main Jul 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(config): add review.path_filters include/negation glob knob

1 participant