feat(engine): add hasPlanSkippedSteps - #3468
Conversation
Return whether any plan DAG step was skipped for miner and dashboard status checks. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3468 +/- ##
=======================================
Coverage 93.01% 93.01%
=======================================
Files 297 298 +1
Lines 31038 31039 +1
Branches 11319 11319
=======================================
+ Hits 28870 28871 +1
Misses 1513 1513
Partials 655 655
🚀 New features to boost your workflow:
|
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-07-05 08:29:55 UTC
🛑 Suggested Action - Reject/Close
Review summary Nits — 2 non-blocking
Why this is blocked
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Gittensory is closing this pull request on the maintainer's behalf (No linked issue detected; Maintainer requires a linked issue). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
hasPlanSkippedStepsin@jsonbored/gittensory-engine— returns whether any step in a plan DAG was skipped.hasPlanFailedSteps,hasPlanPendingSteps, andhasPlanRunningSteps.No linked issue: incremental pure engine export completing the plan-DAG status helper surface (prior merges: #3386, #3390, #3408, #3413, #3435, #3439, #3447); no dedicated tracking issue was filed for this final skipped-status predicate.
Test plan
COVERAGE_NO_THRESHOLDS=1 npx vitest run test/unit/plan-skipped.test.ts --coveragenpx diff-cover coverage/lcov.info --compare-branch=main --fail-under=99→ 100%npm run build --workspace @jsonbored/gittensory-engine && npm run build:minerMade with Cursor