Skip to content

feat(engine): add hasPlanSkippedSteps - #3451

Closed
kiannidev wants to merge 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-has-plan-skipped-steps
Closed

feat(engine): add hasPlanSkippedSteps#3451
kiannidev wants to merge 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-has-plan-skipped-steps

Conversation

@kiannidev

Copy link
Copy Markdown
Contributor

Summary

  • Add hasPlanSkippedSteps in @jsonbored/gittensory-engine — returns whether any step in a plan DAG was skipped.
  • Pure helper completing the plan status surface alongside hasPlanFailedSteps, hasPlanPendingSteps, and hasPlanRunningSteps.
  • Vitest coverage at 100% patch on the new helper.

Test plan

  • COVERAGE_NO_THRESHOLDS=1 npx vitest run test/unit/plan-skipped.test.ts --coverage
  • npx diff-cover coverage/lcov.info --compare-branch=main --fail-under=99 → 100%
  • npm run build --workspace @jsonbored/gittensory-engine && npm run build:miner

Made with Cursor

Expose a pure plan-DAG skipped-step check for miner and dashboard flows that need a quick skipped/not-skipped signal.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev
kiannidev requested a review from JSONbored as a code owner July 5, 2026 07:28
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - reject/close recommended

Review updated: 2026-07-05 08:13:26 UTC

3 files · 1 AI reviewer · 3 blockers · readiness 55/100 · CI green · clean

🛑 Suggested Action - Reject/Close

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.
  • AI reviewers agree on a likely critical defect: PR description: this needs to close or clearly link an eligible open issue before merge
  • add a line like `Closes feat(orb): add POST /v1/orb/ingest central collector endpoint #1234` or explain the maintainer-authorized issue this completes. — Resolve the flagged defect, or override if the AI reviewers are mistaken, then re-run the gate.

Review summary
This adds a small pure plan DAG helper and wires it through the engine barrel, with direct tests for empty, non-skipped, skipped, and barrel-export paths. The implementation itself is correct for the visible `PlanDag` shape: it only reads `plan.steps` and returns whether any status is exactly `skipped`. I cannot mark it merge-ready because the PR description does not close or clearly link an eligible maintainer-authorized issue, which is required for contributor PRs in this repo.

Blockers

Nits — 2 non-blocking
  • PR description: add the required issue link in the summary/footer so the scope is traceable to an accepted repo issue.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.

Why this is blocked

  • PR description: this needs to close or clearly link an eligible open issue before merge; add a line like `Closes feat(orb): add POST /v1/orb/ingest central collector endpoint #1234` or explain the maintainer-authorized issue this completes.
  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.
Signal Result Evidence
Code review ❌ 3 blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 1362 registered-repo PR(s), 668 merged, 49 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 1362 PR(s), 49 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: TypeScript, MDX, C++, HTML, Rust
  • Official Gittensor activity: 1362 PR(s), 49 issue(s).
  • Related work: Titles/paths share 10 meaningful terms. (issue #2276, issue #2278)
  • Related work: Titles/paths share 10 meaningful terms. (issue #2276, issue #2279)
  • Related work: Titles/paths share 11 meaningful terms. (issue #2276, issue #2284)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Explain no-issue PR.
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.99%. Comparing base (f96e067) to head (83784fd).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3451   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files         296      297    +1     
  Lines       30971    30972    +1     
  Branches    11293    11293           
=======================================
+ Hits        28802    28803    +1     
  Misses       1514     1514           
  Partials      655      655           
Files with missing lines Coverage Δ
packages/gittensory-engine/src/plan-skipped.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Gittensory is closing this pull request on the maintainer's behalf (No linked issue detected; Maintainer requires a linked issue; AI reviewers agree on a likely critical defect: PR description: this needs to close or clearly link an eligible open issue before merge; add a line like `Closes #1234` or explain the maintainer-authorized issue this completes.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

@loopover-orb loopover-orb Bot closed this Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant