feat(engine): add hasPlanSkippedSteps - #3451
Conversation
Expose a pure plan-DAG skipped-step check for miner and dashboard flows that need a quick skipped/not-skipped signal. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-07-05 08:13:26 UTC
🛑 Suggested Action - Reject/Close
Review summary Blockers
Nits — 2 non-blocking
Why this is blocked
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3451 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 296 297 +1
Lines 30971 30972 +1
Branches 11293 11293
=======================================
+ Hits 28802 28803 +1
Misses 1514 1514
Partials 655 655
🚀 New features to boost your workflow:
|
|
Gittensory is closing this pull request on the maintainer's behalf (No linked issue detected; Maintainer requires a linked issue; AI reviewers agree on a likely critical defect: PR description: this needs to close or clearly link an eligible open issue before merge; add a line like `Closes #1234` or explain the maintainer-authorized issue this completes.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
hasPlanSkippedStepsin@jsonbored/gittensory-engine— returns whether any step in a plan DAG was skipped.hasPlanFailedSteps,hasPlanPendingSteps, andhasPlanRunningSteps.Test plan
COVERAGE_NO_THRESHOLDS=1 npx vitest run test/unit/plan-skipped.test.ts --coveragenpx diff-cover coverage/lcov.info --compare-branch=main --fail-under=99→ 100%npm run build --workspace @jsonbored/gittensory-engine && npm run build:minerMade with Cursor