Skip to content

test(enrichment): complete provenance classifier coverage for minified and manifest paths - #3450

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bohdansolovie:test/provenance-classifier-coverage-2098
Jul 5, 2026
Merged

test(enrichment): complete provenance classifier coverage for minified and manifest paths#3450
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bohdansolovie:test/provenance-classifier-coverage-2098

Conversation

@bohdansolovie

Copy link
Copy Markdown
Contributor

Fixes #2098

Summary

Completes the remaining classifyAddedFile coverage for the provenance analyzer pure classifiers:

  • Minified bundles (.min.js, .min.mjs, .min.css) classify as vendored
  • Dependency manifests and ordinary source paths (package.json, lockfiles, requirements.txt, src/index.ts) stay null

isSafeToCheck and matchesPypiVersion are already covered in provenance-version-matcher.test.ts.

Test plan

  • cd review-enrichment && npm run build && node --test test/provenance.test.ts test/provenance-version-matcher.test.ts (10 passing)

Made with Cursor

…d and manifest paths (JSONbored#2098)

Cover minified bundles as vendored and dependency manifests as ordinary source alongside existing binary/vendored tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bohdansolovie
bohdansolovie requested a review from JSONbored as a code owner July 5, 2026 07:27
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 07:28:39 UTC

1 file · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This PR only extends the provenance classifier test matrix, and the added assertions align with the stated contract: minified bundle paths classify as vendored while dependency manifests, lockfiles, and normal source paths remain ordinary for this classifier. The test exercises the public `classifyAddedFile` import already used by the file, and CI passed on the exact commit, so I do not see a reachable correctness issue in the visible diff.

Nits — 4 non-blocking
  • nit: review-enrichment/test/provenance.test.ts:75 covers `.min.js`, `.min.mjs`, and `.min.css`, but it does not check case normalization such as `DIST/APP.MIN.JS` if `classifyAddedFile` is expected to be path-normalized like the shared matchers.
  • nit: review-enrichment/test/provenance.test.ts:79 groups dependency manifests, lockfiles, and source paths under one loop; splitting the manifest/lockfile controls from the ordinary source control would make future failures easier to localize.
  • review-enrichment/test/provenance.test.ts:75 Add one mixed-case minified path if `classifyAddedFile` promises case-insensitive matching, for example `assert.equal(classifyAddedFile("DIST/APP.MIN.JS"), "vendored");`.
  • review-enrichment/test/provenance.test.ts:79 Consider separating the `package.json`/lockfile/requirements assertions from `src/index.ts` so a future classifier regression points at the category that changed.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2098
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 267 registered-repo PR(s), 167 merged, 9 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bohdansolovie; Gittensor profile; 267 PR(s), 9 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: bohdansolovie
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 267 PR(s), 9 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit c37daa1 into JSONbored:main Jul 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(enrichment): unit coverage for the provenance analyzer pure classifiers

1 participant