fix(integrations): reject blank project IDs before GitHub calls - #3419
Conversation
GitHubProjectsAdapter.attachToProject and resolveProjectV2Fields now return early when projectId is empty or whitespace-only, avoiding wasted installation-token round-trips and GraphQL errors on malformed input. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 06:44:00 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 5 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3419 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 289 289
Lines 30788 30790 +2
Branches 11221 11223 +2
=======================================
+ Hits 28777 28779 +2
Misses 1355 1355
Partials 656 656
🚀 New features to boost your workflow:
|
Summary
GitHubProjectsAdapter.attachToProjectandresolveProjectV2Fieldsnow return early whenprojectIdis empty or whitespace-only.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlint— no workflow changesnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workers— no worker/runtime changesnpm run build:mcp— no MCP changesnpm run test:mcp-pack— no MCP changesnpm run ui:openapi:check— no UI/API changesnpm run ui:lint— no UI changesnpm run ui:typecheck— no UI changesnpm run ui:build— no UI changesnpm audit --audit-level=moderateIf any required check was skipped, explain why:
src/integrationsand its unit tests.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — no UI changes.
Notes
src/integrations/**only (not a guarded path); intended for auto-merge eligibility once gates pass.Made with Cursor