fix(selfhost): improve codex timeout diagnostics for hung API calls - #3417
Closed
sentry[bot] wants to merge 1 commit into
Closed
fix(selfhost): improve codex timeout diagnostics for hung API calls#3417sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Contributor
|
Gittensory is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-code)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the issue where
selfhost_ai_provider_failed: codex_timeout: Reading prompt from stdin...was reported when the codex CLI subprocess hung due to an unresponsive OpenAI API call, rather than an actual stdin issue.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold).npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
No specific validation steps were provided in the PR description.
Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
Required for visible UI, frontend, docs, or extension changes. Attach GitHub-hosted JPG/JPEG or PNG screenshots here; SVG screenshots are not accepted as review evidence. Use a compact table/grid of clickable thumbnails with a short state/title such as "Loaded state", "Empty state", "Error state", "Mobile layout", or "PR sidebar". Prefer annotated screenshots with a colored box, outline, arrow, or highlighter showing what changed. Recordings can be supplemental, but screenshots are still expected for visual review. Do not commit review-only screenshots, recordings, or
docs/review-evidence/**files.Not applicable, this PR involves backend/utility changes.
Notes
Root Cause: The codex CLI would successfully start and receive its prompt via stdin, but if the underlying OpenAI API call (e.g., for
gpt-5.5witheffort=high) hung and produced no output, the subprocess would eventually be killed by the overalltimeoutMs(600s). Since no JSONL output was ever produced,codexErrorFromStdoutreturned null, and the only captured stderr was the uninformative startup banner "Reading prompt from stdin...". This led to a misleading error message.Solution:
SpawnFn: Modified theSpawnFntype to include an optionalfirstOutputTimeoutMsin its options and anoOutputboolean in its return type.firstOutputTimeoutMsindefaultSpawn: Added a secondary timer that starts when the subprocess is spawned. If no stdout data is received withinfirstOutputTimeoutMs, the child process is killed early, and thenoOutput: trueflag is set in the result. This timer is cleared as soon as any stdout data arrives.createCodexAifunction now passesfirstOutputTimeoutMs: 60_000(60 seconds) to thespawncall. If a timeout occurs andnoOutputis true, a distinct errorcodex_timeout_no_outputis thrown with a more informative message, indicating a potential API connectivity issue. This allows for better Sentry grouping and clearer diagnostics for operators.Fixes GITTENSORY-K