Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/gittensory-engine/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,3 +165,4 @@ export {
type MetadataRankContext,
} from "./opportunity-metadata.js";
export { pickTopMetadataOpportunities } from "./metadata-top-pick.js";
export { rankMetadataOpportunitiesAtOrAboveScore } from "./metadata-min-score.js";
21 changes: 21 additions & 0 deletions packages/gittensory-engine/src/metadata-min-score.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import {
rankMetadataOpportunities,
type MetadataCandidateIssue,
type MetadataRankContext,
} from "./opportunity-metadata.js";
import type { OpportunityRankInput } from "./opportunity-ranker.js";

/**
* Rank metadata candidates and keep only those whose rank score is at or above `minScore`.
* Non-finite thresholds return an empty list. Pure — delegates to {@link rankMetadataOpportunities}.
*/
export function rankMetadataOpportunitiesAtOrAboveScore<T extends MetadataCandidateIssue>(
candidates: readonly T[],
context: MetadataRankContext,
minScore: number,
): Array<T & OpportunityRankInput & { rankScore: number }> {
if (!Number.isFinite(minScore)) return [];
if (candidates.length === 0) return [];
const threshold = Math.min(1, Math.max(0, minScore));
return rankMetadataOpportunities(candidates, context).filter((entry) => entry.rankScore >= threshold);
}
80 changes: 80 additions & 0 deletions test/unit/metadata-min-score.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
import { describe, expect, it } from "vitest";

import { DEFAULT_MINER_GOAL_SPEC } from "../../packages/gittensory-engine/src/miner-goal-spec";
import { rankMetadataOpportunitiesAtOrAboveScore } from "../../packages/gittensory-engine/src/metadata-min-score";

const NOW = Date.parse("2026-07-03T12:00:00.000Z");

const base = {
repoFullName: "acme/widgets",
issueNumber: 10,
title: "Improve queue retry semantics",
labels: ["help wanted"],
commentsCount: 2,
createdAt: "2026-07-01T00:00:00.000Z",
updatedAt: "2026-07-02T12:00:00.000Z",
};

describe("rankMetadataOpportunitiesAtOrAboveScore", () => {
const candidates = [
{ ...base, issueNumber: 1, labels: ["wontfix"] },
{ ...base, issueNumber: 2, labels: ["help wanted"] },
{ ...base, issueNumber: 3, labels: ["help wanted", "bug"] },
];

it("keeps only metadata candidates at or above the score threshold in rank order", () => {
const filtered = rankMetadataOpportunitiesAtOrAboveScore(candidates, { nowMs: NOW }, 0.1);
expect(filtered.map((entry) => entry.issueNumber)).toEqual([3, 2]);
expect(filtered.every((entry) => entry.rankScore >= 0.1)).toBe(true);
});

it("returns every targetable candidate when the threshold is zero", () => {
expect(
rankMetadataOpportunitiesAtOrAboveScore(candidates, { nowMs: NOW }, 0).map((entry) => entry.issueNumber),
).toEqual([3, 2, 1]);
});

it("skips miner-disabled repos before applying the score threshold", () => {
const ranked = rankMetadataOpportunitiesAtOrAboveScore(
[
{ ...base, issueNumber: 1, repoFullName: "acme/disabled" },
{ ...base, issueNumber: 2, labels: ["help wanted"] },
],
{
nowMs: NOW,
goalSpecsByRepo: {
"acme/disabled": { ...DEFAULT_MINER_GOAL_SPEC, minerEnabled: false },
},
},
0,
);
expect(ranked.map((entry) => entry.issueNumber)).toEqual([2]);
});

it("returns an empty array for a non-finite threshold or no candidates", () => {
expect(rankMetadataOpportunitiesAtOrAboveScore(candidates, { nowMs: NOW }, Number.NaN)).toEqual([]);
expect(rankMetadataOpportunitiesAtOrAboveScore(candidates, { nowMs: NOW }, Number.POSITIVE_INFINITY)).toEqual(
[],
);
expect(rankMetadataOpportunitiesAtOrAboveScore([], { nowMs: NOW }, 0.5)).toEqual([]);
});

it("clamps out-of-range thresholds before filtering", () => {
expect(
rankMetadataOpportunitiesAtOrAboveScore(candidates, { nowMs: NOW }, -0.5).map((entry) => entry.issueNumber),
).toEqual([3, 2, 1]);
expect(
rankMetadataOpportunitiesAtOrAboveScore(candidates, { nowMs: NOW }, 1.5).map((entry) => entry.issueNumber),
).toEqual([]);
});

it("is exported from the package barrel", async () => {
const barrel = await import("../../packages/gittensory-engine/src/index");
expect(typeof barrel.rankMetadataOpportunitiesAtOrAboveScore).toBe("function");
expect(
barrel.rankMetadataOpportunitiesAtOrAboveScore(candidates, { nowMs: NOW }, 0.1).map(
(entry: { issueNumber: number }) => entry.issueNumber,
),
).toEqual([3, 2]);
});
});
Loading