Skip to content

test(signals): full-branch coverage for duplicate-winner isDuplicateClusterWinnerByClaim #3311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 5, 2026
Merged

test(signals): full-branch coverage for duplicate-winner isDuplicateClusterWinnerByClaim #3311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions test/unit/duplicate-winner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,36 @@ describe("isDuplicateClusterWinnerByClaim (#dup-winner claim election)", () => {
expect(isDuplicateClusterWinnerByClaim(claim(12, "not-a-date"), [claim(13, "2026-06-29T10:00:00.000Z")])).toBe(false);
expect(isDuplicateClusterWinnerByClaim(claim(13, "2026-06-29T10:00:00.000Z"), [claim(12, "not-a-date")])).toBe(false);
});

it("an empty sibling list ⇒ winner (alone in the cluster)", () => {
expect(isDuplicateClusterWinnerByClaim(claim(12, "2026-06-29T10:00:00.000Z"), [])).toBe(true);
});

it("fails closed when the PR itself has a missing claim timestamp", () => {
expect(isDuplicateClusterWinnerByClaim({ number: 12, linkedIssueClaimedAt: undefined }, [claim(13, "2026-06-29T10:00:00.000Z")])).toBe(false);
});

it("wins when every open sibling claimed later", () => {
expect(
isDuplicateClusterWinnerByClaim(claim(12, "2026-06-29T10:00:00.000Z"), [
claim(13, "2026-06-29T10:05:00.000Z"),
claim(14, "2026-06-29T10:10:00.000Z"),
]),
).toBe(true);
});

it("wins an equal-claim tie when siblings have higher PR numbers", () => {
expect(
isDuplicateClusterWinnerByClaim(claim(12, "2026-06-29T10:00:00.000Z"), [
claim(13, "2026-06-29T10:00:00.000Z"),
claim(14, "2026-06-29T10:00:00.000Z"),
]),
).toBe(true);
});

it("loses an equal-claim tie when any sibling has a lower PR number", () => {
expect(isDuplicateClusterWinnerByClaim(claim(14, "2026-06-29T10:00:00.000Z"), [claim(12, "2026-06-29T10:00:00.000Z")])).toBe(false);
});
});

describe("dupWinnerLinkedDuplicateCount (#dup-winner close-reason seam)", () => {
Expand Down
Loading