test(scoring): cover pure upstream-constant parsers in scoring/model.ts

[jony376]

Summary

Adds a focused unit test file for the pure exports in src/scoring/model.ts so parser/detector helpers reach dedicated branch coverage independent of fetch paths.

Closes #2091.

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npx vitest run test/unit/scoring-model.test.ts
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Full npm run test:ci was started locally (~7 min); the new test file passes in isolation. Remaining unchecked boxes will be validated by CI on this PR (test-only diff under test/**, no src/** changes).

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Not applicable — test-only change.

Notes

• Covers parsePythonNumberConstants, findUnmodeledConstantKeys, findUnmodeledUpstreamConstants, detectActiveModel, scoringSnapshotStalenessWarning, and isTimeDecayEnabled without exercising network fetch paths.

Made with Cursor

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.13%. Comparing base (3875335) to head (7e4d5be).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3303   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files         276      276           
  Lines       30236    30236           
  Branches    11016    11016           
=======================================
  Hits        28464    28464           
  Misses       1127     1127           
  Partials      645      645           

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-05 01:28:59 UTC}

1 file · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This PR adds focused unit coverage for the pure scoring/model helpers without changing production code. The tests exercise numeric parsing, modeled-constant filtering, model detection priority, staleness boundary behavior, and time-decay flag parsing, and the visible assertions line up with the described coverage goal. I do not see a reachable correctness defect in the added test file.

Nits — 4 non-blocking

• nit: test/unit/scoring-model.test.ts:45 calls findUnmodeledConstantKeys(allConstants) repeatedly for related assertions; capture the result once so the test has a single subject value.
• nit: test/unit/scoring-model.test.ts:98 uses "falsey" in the test name; the conventional spelling is "falsy".
• test/unit/scoring-model.test.ts:45 could use `const unmodeled = findUnmodeledConstantKeys(allConstants);` and assert against that value for readability.
• test/unit/scoring-model.test.ts:98 rename the case to `accepts explicit truthy tokens and rejects falsy values`.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#2091
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	❌ 5/25	Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload	✅ 10/10	Author activity: 1006 registered-repo PR(s), 705 merged, 41 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	jony376; Gittensor profile; 1006 PR(s), 41 issue(s).
Gate result	✅ Passing	No configured blocker found.

Review context

• Author: jony376
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: TypeScript, Python, JavaScript, Rust, MDX, Clojure, Cuda, Dart
• Official Gittensor activity: 1006 PR(s), 41 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Await review-lane availability.
• Refresh registry data or choose a registered active repo.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[loopover-orb]

Gittensory approves — the gate is satisfied and CI is green.