fix(engine): cap miner goal list inspection

[JSONbored]

Motivation

• The MinerGoalSpec string-list parser only enforced MAX_LIST_ENTRIES after accepting valid unique strings, allowing malicious or malformed arrays to be scanned unbounded and generate unbounded warnings and CPU/memory work.
• The change bounds the amount of input inspected to prevent resource exhaustion while preserving existing normalization behavior.

Description

• Stop iterating untrusted lists after MAX_LIST_ENTRIES inspected entries by switching to for (const [index, entry] of value.entries()) and breaking with a capped warning when the limit is reached in packages/gittensory-engine/src/miner-goal-spec-parse.ts.
• Emit a clear cap warning when inspection stops early (MinerGoalSpec field "<field>" is capped at 200 entries; dropping the rest.).
• Add regression tests exercising hostile arrays of null entries, duplicates, empty strings, and overlong strings to assert parsing and warning growth are bounded in packages/gittensory-engine/test/miner-goal-spec-parse.test.ts.
• No behavioral changes to accepted normalized entries or exported API surface beyond hardening the input inspection bound.

Testing

• git diff --check passed locally.
• npm --workspace @jsonbored/gittensory-engine test ran the package suite and all tests passed (51 passing, 0 failing), including the new regression tests.
• npm run test:ci could not be completed in this environment due to an external actionlint setup/download DNS failure and the local actionlint WASM fallback flagging a self-hosted runner label, so the full repo gate was not executed here.
• npm audit --audit-level=moderate could not be completed due to the registry audit endpoint returning a 403 in this environment.

---

Codex Task

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	gittensory-ui	33b6b24	Commit Preview URL Branch Preview URL	Jul 04 2026, 04:24 AM

[loopover-orb]

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review result - approve/merge recommended

_{Review updated: 2026-07-04 04:22:35 UTC}

2 files · 1 AI reviewer · no blockers · readiness 93/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
The change correctly bounds `parseStringList` by inspected array position, so hostile arrays made of invalid, duplicate, empty, or overlong entries now stop after 200 inspected items instead of scanning the whole input. The normalized accepted values remain unchanged for the covered cases, and the new tests exercise the real parser path through `parseMinerGoalSpec`. The most notable gap is that the cap warning is only asserted on `wantedPaths`, but the shared helper covers the other list fields through the same call path.

Nits — 4 non-blocking

• nit: `packages/gittensory-engine/test/miner-goal-spec-parse.test.ts:67` asserts only the warning count and final cap warning for invalid entries, so it would not catch accidental changes to the per-entry warning text or ordering before the cap.
• nit: `packages/gittensory-engine/test/miner-goal-spec-parse.test.ts:79` covers the shared list parser only through `wantedPaths`; one representative assertion on another list field would make the call-site coverage clearer.
• In `packages/gittensory-engine/test/miner-goal-spec-parse.test.ts:67`, assert the first invalid-entry warning as well as the final cap warning so the test pins both bounded growth and warning semantics.
• In `packages/gittensory-engine/test/miner-goal-spec-parse.test.ts:79`, add a small `blockedLabels` or `preferredLabels` case to show all list fields use the same inspected-entry cap.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	⚠️ Missing	No linked issue or no-issue rationale found.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 60 registered-repo PR(s), 51 merged, 436 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 60 PR(s), 436 issue(s).
Gate result	✅ Passing	No configured blocker found.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: Python, TypeScript, JavaScript, Ruby, Go, Kotlin, MDX, Shell
• Official Gittensor activity: 60 PR(s), 436 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.
• Explain no-issue PR.
• No action.
• Link the issue being solved, or explicitly explain why this is a no-issue PR.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[loopover-orb]

Gittensory approves — the gate is satisfied and CI is green.