Skip to content

feat(review): add issue RAG query builder - #2660

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
oktofeesh1:codex/miner-issue-rag-query
Jul 3, 2026
Merged

feat(review): add issue RAG query builder#2660
JSONbored merged 1 commit into
JSONbored:mainfrom
oktofeesh1:codex/miner-issue-rag-query

Conversation

@oktofeesh1

Copy link
Copy Markdown
Contributor

Summary

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires >=99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • None. npm run test:ci passed on the rebased branch, and npm audit --audit-level=moderate found 0 vulnerabilities.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A - no visible UI, frontend, docs, or extension change.

Notes

  • No auth, API, MCP, Cloudflare binding, UI, docs, dependency, or migration behavior is changed.

@oktofeesh1
oktofeesh1 requested a review from JSONbored as a code owner July 3, 2026 01:27
@dosubot dosubot Bot added the size:M label Jul 3, 2026
@loopover-orb

loopover-orb Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-03 05:45:02 UTC

3 files · 1 AI reviewer · no blockers · readiness 62/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This change adds a small, focused issue RAG query builder and exports the existing retrieval floor so the new helper uses the same minimum-query threshold as PR retrieval. The implementation is straightforward: it trims title/body/labels, caps body and label count, and returns an empty query below the shared floor. The visible tests cover ordering, truncation, blank fields, and the short-query skip path, so the diff is safe enough to proceed.

Nits — 5 non-blocking
  • nit: src/review/issue-rag-wire.ts:14 preserves duplicate labels, which can waste part of the small query budget when GitHub sends repeated or case-varied labels from a caller fixture.
  • nit: src/review/issue-rag-wire.ts:24 slices the body before composing the final query, so the total embeddable text is only indirectly bounded by title and label assumptions rather than by one final query cap.
  • src/review/issue-rag-wire.ts:14: consider deduplicating normalized labels before slicing so repeated labels do not crowd out issue text.
  • src/review/issue-rag-wire.ts:29: consider applying a final composed-query character cap if this helper may ever be fed non-GitHub input rather than only GitHub-bounded title and label fields.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2320
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (size label size:M; 1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 76 registered-repo PR(s), 69 merged, 4 issue(s).
Contributor context ✅ Confirmed Gittensor contributor oktofeesh1; Gittensor profile; 76 PR(s), 4 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: oktofeesh1
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 76 PR(s), 4 issue(s).
  • Related work: Titles/paths share 9 meaningful terms. (issue #2042, issue #2038)
  • Related work: Titles/paths share 10 meaningful terms. (issue #2038, issue #2039)
  • Related work: Titles/paths share 8 meaningful terms. (issue #2291, issue #2315)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jul 3, 2026
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.10%. Comparing base (066398e) to head (ddf6932).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2660   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         237      238    +1     
  Lines       26540    26555   +15     
  Branches     9625     9631    +6     
=======================================
+ Hits        25507    25522   +15     
  Misses        424      424           
  Partials      609      609           
Files with missing lines Coverage Δ
src/review/issue-rag-wire.ts 100.00% <100.00%> (ø)
src/review/rag.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added the lgtm label Jul 3, 2026
@JSONbored
JSONbored merged commit a2ea220 into JSONbored:main Jul 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Development

Successfully merging this pull request may close these issues.

feat(miner-rag): issue-centric RAG query builder (issue title/body → embeddable query text)

2 participants