Skip to content

fix(signals): match hyphenated refactor-only no-issue rationale - #2418

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
luciferlive112116:fix/signals-refactor-only-no-issue-rationale
Jul 2, 2026
Merged

fix(signals): match hyphenated refactor-only no-issue rationale#2418
JSONbored merged 1 commit into
JSONbored:mainfrom
luciferlive112116:fix/signals-refactor-only-no-issue-rationale

Conversation

@luciferlive112116

@luciferlive112116 luciferlive112116 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

hasClearNoIssueRationale in src/signals/engine.ts is the shared definition of a clear no-issue rationale for the slop signal (#562), the public PR-panel traceability check, and the hard linked-issue gate. After #1905 (docs-only), #1993 (test-only), and #2117 (ci-only), refactor-only PRs using the same Conventional Commits spelling were still missed.

Consequence: a refactor-only PR with no linked issue — e.g. refactor-only: split helper — on a repo with linkedIssueGateMode === "block" can hit hardLinkedIssueBlock, fail the gate, and be auto-closed despite a valid rationale.

Fix: widen the alternative to refactor[\s-]+only, matching refactor only, refactor-only, and embedded body forms while leaving unrelated refactor mentions unchanged.

No linked issue: this repo's linkedIssuePolicy is preferred, and this is a small, self-evident one-token regex correctness fix parallel to the merged docs-only (#1905), test-only (#1993), and ci-only (#2117) fixes.

Scope

Validation

  • git diff --check
  • npm run typecheck
  • npm run test:coverage — new hasClearNoIssueRationale refactor-only spelling tests cover space, hyphenated, embedded body, and negative cases.
  • npm run test:ci

If any required check was skipped, explain why:

  • Node/npm is unavailable in this environment; CI will run the full gate on the PR.

Safety

  • No secrets/wallets/hotkeys; public GitHub output unchanged except correctly recognizing valid rationales.
  • No auth/API/UI change.

Notes

Co-authored-by: Cursor <cursoragent@cursor.com>
@dosubot dosubot Bot added the size:XS label Jul 1, 2026
@loopover-orb

loopover-orb Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-02 05:07:37 UTC

2 files · 1 AI reviewer · no blockers · readiness 73/100 · CI green · unknown

⏸️ Suggested Action - Manual Review

Review summary
The change updates the shared no-issue rationale matcher so `refactor only` and `refactor-only` follow the same spelling rule already used for docs/test/CI-only rationales. The regex change is scoped to the existing helper, preserves the negative case for generic refactor mentions, and the added tests cover the title and body paths that matter for this behavior. I do not see a reachable correctness issue in the diff.

Nits — 1 non-blocking
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2271
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (size label size:XS; 1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 29 registered-repo PR(s), 11 merged, 7 issue(s).
Contributor context ✅ Confirmed Gittensor contributor luciferlive112116; Gittensor profile; 29 PR(s), 7 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: luciferlive112116
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 29 PR(s), 7 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Triage stale or unlinked PRs.
  • Refresh registry data or choose a registered active repo.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.82%. Comparing base (b0c2c32) to head (e1d6f2e).
⚠️ Report is 62 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2418   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files         224      224           
  Lines       24975    24975           
  Branches     9076     9076           
=======================================
  Hits        23933    23933           
  Misses        428      428           
  Partials      614      614           
Files with missing lines Coverage Δ
src/signals/engine.ts 97.71% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added the lgtm label Jul 2, 2026
@JSONbored
JSONbored merged commit 4101ca6 into JSONbored:main Jul 2, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jul 2, 2026
@JSONbored JSONbored removed the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants