Skip to content

feat(signals): recognize testdata paths as test evidence #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luciferlive112116 wants to merge 7 commits into from
Closed

feat(signals): recognize testdata paths as test evidence #2272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
487b221
feat(signals): recognize testdata paths as test evidence
luciferlive112116 Jul 1, 2026
238ebb3
fix(signals): align testdata test with directory-segment matcher
luciferlive112116 Jul 1, 2026
8c42063
fix(signals): delegate engine isTestFile to shared isTestPath helper
luciferlive112116 Jul 1, 2026
20e3bdf
fix(signals): scope testdata PR to evidence classification only
luciferlive112116 Jul 1, 2026
dfc3e8b
fix(signals): add testdata matcher to engine isTestFile
luciferlive112116 Jul 1, 2026
5175118
Merge branch 'main' into feat/signals-testdata-test-evidence
luciferlive112116 Jul 1, 2026
05df84e
Merge branch 'main' into feat/signals-testdata-test-evidence
luciferlive112116 Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/signals/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5474,7 +5474,8 @@ function isTestFile(file: string): boolean {
/(^|\/)src\/test\//i.test(file) ||
/(^|\/)[^/]+_test\.(go|py|rb)$/i.test(file) ||
/(^|\/)[^/]+_spec\.rb$/i.test(file) ||
/\.(test|spec)\.(ts|tsx|js|jsx|py|rb|rs)$/i.test(file)
/\.(test|spec)\.(ts|tsx|js|jsx|py|rb|rs)$/i.test(file) ||
/(^|\/)testdata\//i.test(file)
);
}

Expand Down
3 changes: 2 additions & 1 deletion src/signals/test-evidence.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ export function isTestPath(file: string): boolean {
/(^|\/)[^/]+_spec\.rb$/i.test(file) ||
/\.(test|spec)\.(ts|tsx|js|jsx|py|rb|rs)$/i.test(file) ||
/(^|\/)[^/]+\.(cy|e2e)\.(ts|tsx|js|jsx)$/i.test(file) ||
/(^|\/)__snapshots__\//i.test(file)
/(^|\/)__snapshots__\//i.test(file) ||
/(^|\/)testdata\//i.test(file)
);
}

Expand Down
1 change: 1 addition & 0 deletions test/unit/local-branch-file-classifiers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ describe("isTestFile", () => {

it("delegates to test-evidence isTestPath so matchers stay in sync", () => {
expect(isTestFile("tests/integration/api.test.ts")).toBe(true);
expect(isTestFile("pkg/auth/testdata/golden.json")).toBe(true);
});
});

Expand Down
5 changes: 5 additions & 0 deletions test/unit/test-evidence.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ describe("test evidence helpers", () => {
expect(isTestPath("playwright/smoke.spec.ts")).toBe(true);
expect(isTestPath("cypress/e2e/checkout.cy.js")).toBe(true);
expect(isTestPath("components/__snapshots__/Card.tsx.snap")).toBe(true);
expect(isTestPath("pkg/auth/testdata/golden.json")).toBe(true);
expect(isTestPath("internal/widget/testdata/input.txt")).toBe(true);
expect(isTestPath("src/testdata/client.ts")).toBe(true);
expect(isTestPath("src/state.snap")).toBe(false);
expect(isTestPath("src/widget.rs")).toBe(false);
});
Expand All @@ -22,6 +25,8 @@ describe("test evidence helpers", () => {
expect(isTestPath("src/playwright/client.ts")).toBe(false);
expect(isTestPath("src/cypress/client.ts")).toBe(false);
expect(isTestPath("src/e2e/client.ts")).toBe(false);
expect(isTestPath("src/contestdata/client.ts")).toBe(false);
expect(isTestPath("src/testdatabase/client.ts")).toBe(false);
expect(isTestPath("src/integration/auth.test.ts")).toBe(true);
expect(isTestPath("src/playwright/client.e2e.ts")).toBe(true);
expect(isTestPath("src/cypress/client.cy.ts")).toBe(true);
Expand Down
Loading