feat(extension): add private maintainer PR sidebar context - #224
Conversation
257d650 to
36c3876
Compare
|
@JSONbored Fixed all conflicts and all CI green. |
JSONbored
left a comment
There was a problem hiding this comment.
@bittoby this is close. The sidebar work is substantial, and the added sanitizer/fallback coverage is the right kind of protection for private maintainer context.
A few notes:
- The current code path looks much healthier after the conflict fix and CI is green.
- The remaining blocker is review evidence, not the implementation shape.
- This changes visible extension/UI behavior, so checklist text is not enough.
Required changes:
- Add actual screenshot or short recording evidence for the GitHub PR sidebar.
- Include the visible states that matter: loaded maintainer context, empty/fallback/error handling if those render differently, and any settings/preview surface affected by this PR.
Validation expected:
- Keep
npm run test:cigreen. - Reconfirm the extension UI screenshot/recording is attached in the PR body or a comment.
f97ec70 to
c920f38
Compare
|
@JSONbored I've updated all. Pls review again |
JSONbored
left a comment
There was a problem hiding this comment.
@bittoby hi, i'm not seeing the screenshots in the PR description - can you please add them as thumbnails, not as committed files?
25c8884 to
735ac2d
Compare
|
@JSONbored Updated PR description |
JSONbored
left a comment
There was a problem hiding this comment.
@bittoby this is closer, but the evidence format still needs one more cleanup.
A few notes:
- The private PR sidebar scope matches #146.
- The screenshots are attached in the PR description, which is the right place.
- They still need to be organized as captioned clickable thumbnails, not just standalone image tags.
Required changes:
- Retitle the PR to a scoped title, for example
feat(extension): add private maintainer PR sidebar context. - Convert the screenshots into a compact table/grid with state captions like
Loaded state,Empty fallback, andError state. - Make each thumbnail clickable through to the full-size GitHub-hosted image.
- Instructions should be in our Contribution guidelines now, I added them earlier today for easier reference.
Personally, I also think the extension needs a lot of work in terms of design/layout/simplifications (horribly text-heavy right now) but we'll get to that in another feature sprint.
Validation expected:
- Keep the current green checks.
- Reconfirm no review-only screenshots are committed to the repo.
…t/146-extension-pr-context-sidebar
05e9149 to
14080ec
Compare
|
@JSONbored I've updated. |
JSONbored
left a comment
There was a problem hiding this comment.
@bittoby this looks much closer now.
A few notes:
- The screenshots are now in the PR description as captioned clickable thumbnails.
- The extension sidebar scope and sanitizer coverage are aligned with #146.
- I do not see a new code blocker from this pass, but the PR still has an active requested-changes review state.
Required changes:
- None, however we need to plan followup PRs to get this extension design massively overhauled + improved, the current design is rough.
Validation expected:
- Keep the current green CI.
|
Hi @bittoby please fix failing CI, slightly under testing coverage gate. Be sure proper invariants/regression testing where applicable. Let me know once done, everything else looks ready. |
|
@JSONbored Fixed CI error. pls review again |
JSONbored
left a comment
There was a problem hiding this comment.
@bittoby this is ready from this pass.
A few notes:
- The private maintainer sidebar work is scoped to the extension surface and covered by content-script/API assertions.
- The screenshot evidence is in the PR description as captioned clickable thumbnails for loaded, empty, and error states.
- Validation evidence is complete and the branch is clean against current
main.
No code changes are requested from this review pass.
Closes #146
Summary
Scope
CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragenpm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:cipassed locally; branch coverage was 97.05%.Screenshots
Screenshots are uploaded as GitHub-hosted PR attachments, not committed files. Each thumbnail links to the full-size image.
Safety
Notes