Skip to content

feat(extension): add private maintainer PR sidebar context - #224

Merged
JSONbored merged 6 commits into
JSONbored:mainfrom
Crystora:feat/146-extension-pr-context-sidebar
Jun 4, 2026
Merged

feat(extension): add private maintainer PR sidebar context#224
JSONbored merged 6 commits into
JSONbored:mainfrom
Crystora:feat/146-extension-pr-context-sidebar

Conversation

@Crystora

@Crystora Crystora commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Closes #146

Summary

  • Completes the browser extension PR context sidebar with private maintainer sections for miner context, lane fit, duplicate risk, linked issue state, queue pressure, public-safe actions, and safety boundaries.
  • Adds extension content-script coverage and API integration assertions for confirmed miner, non-miner, redaction, fallback rendering, and sanitizer behavior.

Scope

  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked an issue.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries.

If any required check was skipped, explain why:

  • No required automated check was skipped. Full npm run test:ci passed locally; branch coverage was 97.05%.

Screenshots

Screenshots are uploaded as GitHub-hosted PR attachments, not committed files. Each thumbnail links to the full-size image.

Loaded state Empty fallback Error state
Loaded state: private maintainer PR sidebar with populated context sections Empty fallback: private maintainer PR sidebar with no context available Error state: private maintainer PR sidebar with API failure message

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include screenshots or a short recording.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

Notes

  • Screenshot evidence is attached in the PR description as captioned clickable thumbnails.

@Crystora
Crystora requested a review from JSONbored as a code owner June 2, 2026 01:08
@dosubot dosubot Bot added the size:L label Jun 2, 2026
@dosubot dosubot Bot added size:XL and removed size:L labels Jun 2, 2026
@Crystora
Crystora force-pushed the feat/146-extension-pr-context-sidebar branch from 257d650 to 36c3876 Compare June 2, 2026 05:02
@Crystora

Crystora commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

@JSONbored Fixed all conflicts and all CI green.

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bittoby this is close. The sidebar work is substantial, and the added sanitizer/fallback coverage is the right kind of protection for private maintainer context.

A few notes:

  • The current code path looks much healthier after the conflict fix and CI is green.
  • The remaining blocker is review evidence, not the implementation shape.
  • This changes visible extension/UI behavior, so checklist text is not enough.

Required changes:

  • Add actual screenshot or short recording evidence for the GitHub PR sidebar.
  • Include the visible states that matter: loaded maintainer context, empty/fallback/error handling if those render differently, and any settings/preview surface affected by this PR.

Validation expected:

  • Keep npm run test:ci green.
  • Reconfirm the extension UI screenshot/recording is attached in the PR body or a comment.

@Crystora
Crystora force-pushed the feat/146-extension-pr-context-sidebar branch 4 times, most recently from f97ec70 to c920f38 Compare June 2, 2026 13:08
@Crystora

Crystora commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

@JSONbored I've updated all. Pls review again

@JSONbored
JSONbored self-requested a review June 2, 2026 16:54

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bittoby hi, i'm not seeing the screenshots in the PR description - can you please add them as thumbnails, not as committed files?

@Crystora
Crystora force-pushed the feat/146-extension-pr-context-sidebar branch from 25c8884 to 735ac2d Compare June 2, 2026 17:27
@Crystora

Crystora commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

@JSONbored Updated PR description

@JSONbored
JSONbored self-requested a review June 3, 2026 05:29

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bittoby this is closer, but the evidence format still needs one more cleanup.

A few notes:

  • The private PR sidebar scope matches #146.
  • The screenshots are attached in the PR description, which is the right place.
  • They still need to be organized as captioned clickable thumbnails, not just standalone image tags.

Required changes:

  • Retitle the PR to a scoped title, for example feat(extension): add private maintainer PR sidebar context.
  • Convert the screenshots into a compact table/grid with state captions like Loaded state, Empty fallback, and Error state.
  • Make each thumbnail clickable through to the full-size GitHub-hosted image.
  • Instructions should be in our Contribution guidelines now, I added them earlier today for easier reference.

Personally, I also think the extension needs a lot of work in terms of design/layout/simplifications (horribly text-heavy right now) but we'll get to that in another feature sprint.

Validation expected:

  • Keep the current green checks.
  • Reconfirm no review-only screenshots are committed to the repo.

@JSONbored JSONbored changed the title feat: add a private GitHub PR sidebar context panel for extension maintainers feat(extension): add a private GitHub PR sidebar context panel for extension maintainers Jun 3, 2026
@Crystora Crystora changed the title feat(extension): add a private GitHub PR sidebar context panel for extension maintainers feat(extension): add private maintainer PR sidebar context Jun 3, 2026
@Crystora
Crystora force-pushed the feat/146-extension-pr-context-sidebar branch from 05e9149 to 14080ec Compare June 3, 2026 12:05
@Crystora

Crystora commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

@JSONbored I've updated.

@JSONbored
JSONbored self-requested a review June 3, 2026 22:23
JSONbored
JSONbored previously approved these changes Jun 3, 2026

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bittoby this looks much closer now.

A few notes:

  • The screenshots are now in the PR description as captioned clickable thumbnails.
  • The extension sidebar scope and sanitizer coverage are aligned with #146.
  • I do not see a new code blocker from this pass, but the PR still has an active requested-changes review state.

Required changes:

  • None, however we need to plan followup PRs to get this extension design massively overhauled + improved, the current design is rough.

Validation expected:

  • Keep the current green CI.

@dosubot dosubot Bot added the lgtm label Jun 3, 2026
@JSONbored

Copy link
Copy Markdown
Owner

Hi @bittoby please fix failing CI, slightly under testing coverage gate. Be sure proper invariants/regression testing where applicable. Let me know once done, everything else looks ready.

@Crystora

Crystora commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

@JSONbored Fixed CI error. pls review again

@Crystora
Crystora requested a review from JSONbored June 4, 2026 01:27

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bittoby this is ready from this pass.

A few notes:

  • The private maintainer sidebar work is scoped to the extension surface and covered by content-script/API assertions.
  • The screenshot evidence is in the PR description as captioned clickable thumbnails for loaded, empty, and error states.
  • Validation evidence is complete and the branch is clean against current main.

No code changes are requested from this review pass.

@JSONbored
JSONbored merged commit 9bc293b into JSONbored:main Jun 4, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 4, 2026
@JSONbored JSONbored added gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. and removed feature gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

feat(extension): add PR sidebar Gittensory context panel

2 participants