feat(signals): treat __fixtures__ and __mocks__ paths as test evidence - #2105
feat(signals): treat __fixtures__ and __mocks__ paths as test evidence#2105kiannidev wants to merge 2 commits into
Conversation
Count Jest and Vitest fixture/mock directories when classifying local test coverage and slop missing-test-evidence signals. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2105 +/- ##
==========================================
- Coverage 95.71% 0 -95.72%
==========================================
Files 222 0 -222
Lines 24653 0 -24653
Branches 8945 0 -8945
==========================================
- Hits 23597 0 -23597
+ Misses 433 0 -433
+ Partials 623 0 -623 🚀 New features to boost your workflow:
|
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-07-01 11:38:52 UTC
🛑 Suggested Action - Reject/Close
Review summary Blockers
Nits — 5 non-blocking
Why this is blocked
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
JSONbored
left a comment
There was a problem hiding this comment.
Closing, see review for blockers.
src/signals/engine.ts:isTestFile still omits `__fixtures__` and `__mocks__`, so a PR that only adds `src/__fixtures__/user.json` or `lib/__mocks__/fetch.ts` will be counted as test evidence by `src/signals/test-evidence.ts:isTestPath` but not by the engine's duplicate matcher.
Summary
__fixtures__and__mocks__directories as test paths inisTestPath.No-issue rationale
Small slop/test-evidence hardening with no linked issue.
Test plan
npx vitest run test/unit/test-evidence.test.tsMade with Cursor