Skip to content

[codex] Limit GitHub webhook request bodies - #198

Closed
jeffreyzeng10 wants to merge 1 commit into
JSONbored:mainfrom
jeffreyzeng10:codex/webhook-body-limit
Closed

[codex] Limit GitHub webhook request bodies#198
jeffreyzeng10 wants to merge 1 commit into
JSONbored:mainfrom
jeffreyzeng10:codex/webhook-body-limit

Conversation

@jeffreyzeng10

@jeffreyzeng10 jeffreyzeng10 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add an early 10 MB Content-Length gate for GitHub webhooks
  • read webhook streams with the same byte limit before signature verification
  • document the new 413 webhook response and refresh the UI OpenAPI artifact
  • cover the new limit/error branches with unit/integration tests

Closes #196

Validation

  • npm run typecheck
  • npx vitest run test/unit/webhook.test.ts test/integration/api.test.ts
  • npm run test:coverage
  • npm run ui:openapi:check
  • git diff --check

@jeffreyzeng10
jeffreyzeng10 force-pushed the codex/webhook-body-limit branch from cb4c8fc to c184e7d Compare June 1, 2026 16:54
@jeffreyzeng10
jeffreyzeng10 force-pushed the codex/webhook-body-limit branch from c184e7d to 15a079f Compare June 1, 2026 16:56
@jeffreyzeng10
jeffreyzeng10 marked this pull request as ready for review June 1, 2026 16:59
@jeffreyzeng10
jeffreyzeng10 requested a review from JSONbored as a code owner June 1, 2026 16:59
@dosubot dosubot Bot added the size:M label Jun 1, 2026
@JSONbored JSONbored added the bug label Jun 1, 2026
@JSONbored

Copy link
Copy Markdown
Owner

@jeffreyzeng10 Thanks for the focused webhook body-limit patch. The implementation is clean, but it now overlaps with an earlier viable first-mover PR in the same webhook hardening area.

I’m going to close this in favor of #197 under our duplicate-submission policy. If there is a specific correctness, security, or scope reason this branch should supersede the first submission, call that out explicitly and we can reconsider.

@JSONbored JSONbored closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unauthenticated GitHub Webhook DoS via Large Request Bodies

2 participants