Skip to content

fix(signals): redact /var/ paths in the manifest public-safe guard #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jun 29, 2026
Merged

fix(signals): redact /var/ paths in the manifest public-safe guard #1749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/signals/focus-manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,10 +289,11 @@ const EMPTY_MANIFEST: FocusManifest = {
* text must not leak reward, wallet/key, ranking, or local filesystem path material.
*/
export function isFocusManifestPublicSafe(text: string): boolean {
// Local filesystem path alternatives mirror the canonical PUBLIC_UNSAFE_PATTERN in redaction.ts: include
// `/root/` (container/CI home) and accept the forward-slash Windows form (`C:/Users/`), not only the
// backslash one — otherwise a `/root/...` or `C:/Users/...` path leaks through this public-safe guard.
return !/\b(reward\w*|score\w*|wallets?|hotkeys?|coldkeys?|seed[-\s]?phrases?|mnemonics?|private[-\s]?keys?|farming|payouts?|rankings?|raw[-\s]?trust(?:[-\s]?scores?)?|trust[-\s]?scores?|private[-\s]?reviewability|reviewability(?:[-\s]?internals?)?|private[-\s]?scoreability|scoreability|public[-\s]?score[-\s]?(?:estimate|prediction|claim)s?|estimated[-\s]?scores?|score[-\s]?(?:estimate|prediction|preview)s?)\b|\/Users\/|\/home\/|\/root\/|\/tmp\/|[A-Z]:[\\/]Users[\\/]/i.test(text);
// Local filesystem path alternatives mirror the canonical PUBLIC_UNSAFE_PATTERN in redaction.ts: the full
// set is `/Users/`, `/home/`, `/root/` (container/CI home), `/var/` (logs, temp, CI workspaces), `/tmp/`,
// and the Windows `[A-Z]:[\/]Users[\/]` form (both slash directions). Any omission leaks that path prefix
// through this public-safe guard.
return !/\b(reward\w*|score\w*|wallets?|hotkeys?|coldkeys?|seed[-\s]?phrases?|mnemonics?|private[-\s]?keys?|farming|payouts?|rankings?|raw[-\s]?trust(?:[-\s]?scores?)?|trust[-\s]?scores?|private[-\s]?reviewability|reviewability(?:[-\s]?internals?)?|private[-\s]?scoreability|scoreability|public[-\s]?score[-\s]?(?:estimate|prediction|claim)s?|estimated[-\s]?scores?|score[-\s]?(?:estimate|prediction|preview)s?)\b|\/Users\/|\/home\/|\/root\/|\/var\/|\/tmp\/|[A-Z]:[\\/]Users[\\/]/i.test(text);
}

function emptyManifest(source: FocusManifestSource, warnings: string[] = []): FocusManifest {
Expand Down
1 change: 1 addition & 0 deletions test/unit/focus-manifest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,7 @@ describe("public-safe invariant", () => {
expect(isFocusManifestPublicSafe("see /Users/me/repo/src")).toBe(false);
expect(isFocusManifestPublicSafe("see /home/dev/repo/src")).toBe(false);
expect(isFocusManifestPublicSafe("see /root/repo/src")).toBe(false);
expect(isFocusManifestPublicSafe("see /var/log/build.log")).toBe(false);
expect(isFocusManifestPublicSafe("see /tmp/build/out")).toBe(false);
// Windows, both backslash and forward-slash forms.
expect(isFocusManifestPublicSafe("see C:\\Users\\me\\repo")).toBe(false);
Expand Down
Loading