fix(gate): advisory signals never drive a close — dry-run promotes only the AI sub-gate - #1590
Merged
Merged
Conversation
…s) never drive a close — even in dry-run #disposition-redesign. promoteAdvisoryToBlock (the dry-run shadow eval that produces displayConclusion) was promoting EVERY advisory sub-gate to block, so a missing linked issue or a sub-threshold readiness score rendered a would-be 'close' verdict in the unified comment — wrong. A missing linked issue and readiness are ADVISORY signals only; the CLOSE disposition is driven by the AI reviewer's confidence + genuine hard blockers (secret/CI/banned). So the dry-run shadow now promotes ONLY the AI sub-gate: an advisory AI defect still previews its would-be close, while linked-issue / readiness / slop / duplicates can never reach a close (real OR dry-run preview). Posted check stays non-enforcing.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1590 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 202 202
Lines 21891 21891
Branches 7911 7911
=======================================
Hits 20901 20901
Misses 414 414
Partials 576 576
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A missing linked issue and readiness are advisory signals only — they must never drive a
closedisposition.promoteAdvisoryToBlock(the #1588 dry-run shadow) wrongly promoted every advisory sub-gate to block, so a missing linked issue or a low readiness score rendered a would-be close in the comment. Now the shadow promotes only the AI sub-gate: an advisory AI defect still previews its would-be close, while linked-issue / readiness / slop / duplicates can never reach a close (real or dry-run). First step of the disposition redesign toward AI-confidence-driven close. Fully covered.