feat(sync): update upstream drift issues by fingerprint - #156
Merged
JSONbored merged 6 commits intoJun 1, 2026
Conversation
Contributor
Author
|
@JSONbored can you please review my PR? |
JSONbored
approved these changes
Jun 1, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@MkDev11 This is ready from my side.
A few notes:
- The updated flow handles the important operational case: existing open drift reports now update the existing GitHub issue instead of silently skipping once an
issueUrlis present. - The
recordedGitHubIssue(...) ?? findGitHubIssueForFingerprint(...)order is right. It avoids unnecessary issue-list scans when the report already has a canonical issue number, while still preserving fingerprint recovery for older records. - The shared create/update payload helpers keep the issue title, labels, assignees, marker, changed upstream source summary, and suggested tests aligned across both paths.
- The new tests cover create, update by fingerprint, direct linked-issue update, failed update, malformed payload, source-path summaries, and public-safe body language.
- Current
validate, Contributor trust, and Superagent checks are green, and the merge-tree is clean.
No requested changes from me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run test:ciSafety