feat(notify): add Slack per-action notifications alongside Discord - #1487
Merged
Conversation
Operator notifications were Discord-only. Add notifyActionToSlack as a sibling of notifyActionToDiscord: when SLACK_WEBHOOK_URL (a hooks.slack.com/services webhook) is set, a merged/closed/manual outcome posts a Block Kit message to that channel for ANY repo. The executor now fires both; set either, both, or neither. Best-effort (never throws), URL-validated to hooks.slack.com/services only.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
JSONbored
added
the
gittensor:feature
JSONbored
added this to the
M3 — Agent Layer Phase 1 (maintainer auto-maintain) milestone
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1487 +/- ##
=======================================
Coverage 95.44% 95.44%
=======================================
Files 194 194
Lines 21078 21094 +16
Branches 7625 7629 +4
=======================================
+ Hits 20118 20134 +16
Misses 383 383
Partials 577 577
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Operator notifications were Discord-only. This adds
notifyActionToSlackas a sibling ofnotifyActionToDiscord: whenSLACK_WEBHOOK_URL(ahttps://hooks.slack.com/services/…incoming webhook) is set, a merged / closed / manual outcome posts a Block Kit message to that channel for any repo. The action executor now fires both — set either, both, or neither.hooks.slack.com/servicesonly (https).env.d.ts+.env.example.Validation
npm run typecheck;npm run test:coverage— full suite green; 100% changed lines + branches (posts with/without submitter; unset + 4 invalid-URL shapes → no-op; fetch failure swallowed).Roadmap item #11 (integrations).