chore(rag): remove the dead populateRepoIndexStub / INDEX_JOB_FOLLOWUP artifacts - #1484
Merged
Conversation
…P artifacts These were a documented stub + a follow-up marker left from when RAG retrieval shipped ahead of index population. Population has since been fully implemented in rag-index.ts (fetch tree → chunk → embed → upsert, scheduled from the cron + merged-PR webhooks), so the stub is dead code that only ever misled readers into thinking RAG was inert. Remove it + its test and correct the now-stale comments.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
- Coverage 95.44% 95.44% -0.01%
==========================================
Files 194 194
Lines 21070 21066 -4
Branches 7624 7624
==========================================
- Hits 20110 20106 -4
Misses 383 383
Partials 577 577
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
populateRepoIndexStub+ theINDEX_JOB_FOLLOWUPmarker inrag-wire.tswere a documented stub + ticket left from when RAG retrieval shipped ahead of index population. Population has since been fully implemented inrag-index.ts(fetch tree → chunk → embed → upsert, scheduled from the six-hourly cron fan-out + merged-PR webhooks).So the stub is dead code that only misled readers into thinking RAG was inert (it tripped up a recent audit). Remove the stub + its test and correct the now-stale comments to point at the real implementation.
Validation
npm run typecheck;npm run test:coverage— full suite green; deletion-only onsrc/**(no new coverage obligation; the removed code's only test is removed with it). Symbols (upsertChunks/splitRepo/createReviewAdapters) remain used elsewhere, so no unused imports.Roadmap item #12 (hygiene).