feat(engine): close blacklisted contributors' PRs ahead of merit (#1425) - #1431
Closed
JSONbored wants to merge 1 commit into
Closed
feat(engine): close blacklisted contributors' PRs ahead of merit (#1425)#1431JSONbored wants to merge 1 commit into
JSONbored wants to merge 1 commit into
Conversation
A PR from a blacklisted login short-circuits the agent disposition to a deterministic label (`blacklistLabel`, default "slop") + close, ahead of all merit/CI/gate/AI analysis, with a sanitized close comment and no AI call. The close wins over the normal gate disposition (`closeKind: "blacklist"", exempt from AI refutation like the linked-issue hard rule). Honors the autonomy dial and agentPaused/agentDryRun; the owner and automation bots are never auto-closed. The per-repo list is resolved today; the shared/global list unions in once its table lands. Advances #1425.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## claude/blacklist-label #1431 +/- ##
=======================================================
Coverage 95.39% 95.40%
=======================================================
Files 193 193
Lines 20932 20945 +13
Branches 7566 7573 +7
=======================================================
+ Hits 19969 19982 +13
Misses 383 383
Partials 580 580
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The engine disposition for the anti-abuse contributor blacklist (#1425). A PR from a blacklisted
login short-circuits the agent maintenance planner to a deterministic label + close, ahead of all
merit / CI / gate / AI analysis — with a sanitized close comment and no AI call.
Behavior
produces
[label, close]and returns — the PR is never merit-reviewed or auto-merged.blacklistLabel(defaultslop); works regardless of thelabel a repo sets — nothing hard-coded.
reasonis run through the existing public-safe sanitizer, so aprivate term can never leak into the PR thread.
agentPaused/agentDryRunexactlylike every other agent action;
closeKind: "blacklist"is exempt from AI refutation (like thelinked-issue hard rule). The owner and automation bots are never auto-closed.
Scope
wantedPaths; nosite//CNAME/lovable; no changelog edit.mergeContributorBlacklists) is in place for when the global table lands.Validation
npm run typechecknpm run test:coverage— full suite green; 100% of changed lines and branches covered.Safety
sanitizePublicComment; a forbidden term in the reason is asserted absent.Advances #1425.