Skip to content

test(review): cover planner AI-Gateway route + title/body fallbacks - #1361

Merged
JSONbored merged 1 commit into
mainfrom
test/planner-branch-coverage
Jun 25, 2026
Merged

test(review): cover planner AI-Gateway route + title/body fallbacks#1361
JSONbored merged 1 commit into
mainfrom
test/planner-branch-coverage

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

Test-only follow-up to #1360. That PR's head ref was stuck on the pre-fix commit when it merged (a GitHub PR-sync lag), so the two extra planner.ts coverage cases were left behind. This restores them:

  • the AI_GATEWAY_ID route in runPlannerModel (the gateway extra is threaded as the 3rd AI.run arg);
  • the title || "(none)" / body || "(no description provided)" fallbacks in generateIssuePlan.

With these, src/review/planner.ts is back to 100% line + branch coverage.

No linked issue — a coverage-completion follow-up to #1360.

Scope

  • Test-only (test/unit/planner.test.ts) — no src/ change, so no codecov/patch obligation

Validation

  • npm run typecheck — clean
  • npx vitest run test/unit/planner.test.ts — 11 pass
  • npm run test:coverageplanner.ts shows no uncovered lines and no partial branches

Restores the two planner.ts branches (the AI_GATEWAY_ID ternary and the
title/description fallback strings) that the #1360 merge missed when its head
ref was stuck on the pre-fix commit. Test-only — no src change.
@dosubot dosubot Bot added the size:XS label Jun 25, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.35%. Comparing base (4f52e3c) to head (83eb9e0).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1361   +/-   ##
=======================================
  Coverage   95.34%   95.35%           
=======================================
  Files         191      191           
  Lines       20652    20652           
  Branches     7460     7460           
=======================================
+ Hits        19690    19692    +2     
  Misses        378      378           
+ Partials      584      582    -2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored
JSONbored merged commit 9605058 into main Jun 25, 2026
18 checks passed
@JSONbored
JSONbored deleted the test/planner-branch-coverage branch June 25, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant