test(review): cover planner AI-Gateway route + title/body fallbacks - #1361
Merged
Conversation
Restores the two planner.ts branches (the AI_GATEWAY_ID ternary and the title/description fallback strings) that the #1360 merge missed when its head ref was stuck on the pre-fix commit. Test-only — no src change.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1361 +/- ##
=======================================
Coverage 95.34% 95.35%
=======================================
Files 191 191
Lines 20652 20652
Branches 7460 7460
=======================================
+ Hits 19690 19692 +2
Misses 378 378
+ Partials 584 582 -2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only follow-up to #1360. That PR's head ref was stuck on the pre-fix commit when it merged (a GitHub PR-sync lag), so the two extra
planner.tscoverage cases were left behind. This restores them:AI_GATEWAY_IDroute inrunPlannerModel(the gatewayextrais threaded as the 3rdAI.runarg);title || "(none)"/body || "(no description provided)"fallbacks ingenerateIssuePlan.With these,
src/review/planner.tsis back to 100% line + branch coverage.No linked issue — a coverage-completion follow-up to #1360.
Scope
test/unit/planner.test.ts) — nosrc/change, so nocodecov/patchobligationValidation
npm run typecheck— cleannpx vitest run test/unit/planner.test.ts— 11 passnpm run test:coverage—planner.tsshows no uncovered lines and no partial branches