fix(content-lane): reject multi-entry registry submissions - #1319
Merged
JSONbored merged 3 commits intoJun 26, 2026
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1319 +/- ##
=======================================
Coverage 95.37% 95.37%
=======================================
Files 192 192
Lines 20852 20854 +2
Branches 7540 7541 +1
=======================================
+ Hits 19887 19889 +2
Misses 383 383
Partials 582 582
🚀 New features to boost your workflow:
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 11dbad8 | Commit Preview URL Branch Preview URL |
Jun 25 2026, 11:05 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
not-direct-submissionand thus causedrunSurfaceReviewto returnnull, letting the generic gate (which may auto-merge) handle malformed registry submissions.Description
classifyRegistryPrScopeto treat registry-looking PRs with multiple direct entry files, or multiple standalone provider files, asmixed-filesby returning{ scope: "mixed-files", directFile: null, isProvider: false }early.not-direct-submission.test/unit/content-lane-orchestrator.test.tsthat asserts a multi-entry registry submission receives acloseverdict and does not attempt to load registry files.test/unit/content-lane-registry-logic.test.tsexpectations for multi-entry cases to assertmixed-filesfor both metagraphed and minimal/bare specs.Testing
npx vitest run test/unit/content-lane-orchestrator.test.ts test/unit/content-lane-registry-logic.test.ts, and those tests passed.git diff --check(no whitespace/conflict issues) locally.npm run test:ci, but the run in this environment encountered long-running unrelated test timings and network/setup issues before completion;npm audit --audit-level=moderatereturned403 Forbiddenagainst the npm registry in this environment, which prevented a full cleantest:civalidation here.Codex Task