Skip to content

fix(content-lane): limit registry provider companions #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JSONbored wants to merge 3 commits into from
Closed

fix(content-lane): limit registry provider companions #1312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbdd03e
fix(content-lane): limit registry provider companions
JSONbored Jun 25, 2026
11ed6ae
Merge branch 'main' into codex/propose-fix-for-registry-classifier-vu…
JSONbored Jun 26, 2026
f837b19
Merge branch 'main' into codex/propose-fix-for-registry-classifier-vu…
JSONbored Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/review/content-lane/registry-logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,9 +679,9 @@ export interface RegistryScopeResult {

/**
* Generic surface-model scope classifier: in scope when the PR edits exactly ONE entry file (or, entry-free,
* one flat provider file); the spec's provider + artifact files are allowed companions. A registry-looking
* submission with too many entry/provider files is malformed and stays in the lane as mixed-files; an unrelated
* PR with no direct registry files remains not-direct-submission.
* one flat provider file); at most one provider plus the spec's artifact files are allowed companions. A
* registry-looking submission with too many entry/provider files is malformed and stays in the lane as
* mixed-files; an unrelated PR with no direct registry files remains not-direct-submission.
*/
export function classifyRegistryPrScope(spec: RegistryLaneSpec, changedFiles: string[]): RegistryScopeResult {
const files = (changedFiles ?? []).map((f) => String(f || "").trim()).filter(Boolean);
Expand All @@ -690,7 +690,7 @@ export function classifyRegistryPrScope(spec: RegistryLaneSpec, changedFiles: st
if (entryFiles.length > 1 || (entryFiles.length === 0 && providerFiles.length > 1)) {
return { scope: "mixed-files", directFile: null, isProvider: false };
}
const isEntryPr = entryFiles.length === 1;
const isEntryPr = entryFiles.length === 1 && providerFiles.length <= 1;
const isProviderPr = entryFiles.length === 0 && providerFiles.length === 1;
if (!isEntryPr && !isProviderPr) {
return { scope: "not-direct-submission", directFile: null, isProvider: false };
Expand Down
11 changes: 11 additions & 0 deletions test/unit/content-lane-registry-logic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,17 @@ describe("classifyRegistryPrScope (generic surface model, metagraphed spec)", ()
expect(r.directFile).toBe("registry/subnets/allways.json");
});

it("rejects an entry-submission with multiple flat provider companions", () => {
const r = classifyRegistryPrScope(spec, [
"registry/subnets/allways.json",
"registry/providers/allways.json",
"registry/providers/extra.json",
]);
expect(r.scope).toBe("not-direct-submission");
expect(r.directFile).toBeNull();
expect(r.isProvider).toBe(false);
});

it("recognizes a standalone flat provider-submission (no subnet file)", () => {
const r = classifyRegistryPrScope(spec, ["registry/providers/cacheon.json"]);
expect(r.scope).toBe("provider-submission");
Expand Down
Loading