feat(signals): extend public redaction for /var and Program Files paths - #1307
Closed
jaso0n0818 wants to merge 2 commits into
Closed
feat(signals): extend public redaction for /var and Program Files paths#1307jaso0n0818 wants to merge 2 commits into
jaso0n0818 wants to merge 2 commits into
Conversation
Expand the shared PUBLIC_UNSAFE_PATTERN so maintainer-facing copy cannot leak common Linux /var or Windows Program Files filesystem paths (JSONbored#542). Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 192 192
Lines 20750 20750
Branches 7500 7500
=======================================
Hits 19783 19783
Misses 383 383
Partials 584 584
🚀 New features to boost your workflow:
|
7 tasks
JSONbored
reviewed
Jun 26, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
Verdict: CLOSE — base conflict · hands-off, owner executes.
Correct/minimal redaction extension, but CONFLICTING.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the shared
PUBLIC_UNSAFE_PATTERNinredaction.tsso public GitHub surfaces also redact common Linux/var/and WindowsProgram Filesinstall paths (#542 follow-up).New blocked paths:
/var/...(e.g./var/log/app.log)C:\Program Files\...style Windows install directoriesTest plan
git diff --checknpm run typechecknpm test -- test/unit/redaction.test.ts