Skip to content

feat(signals): extend public redaction for /var and Program Files paths - #1307

Closed
jaso0n0818 wants to merge 2 commits into
JSONbored:mainfrom
jaso0n0818:feat/signals-redaction-system-paths
Closed

feat(signals): extend public redaction for /var and Program Files paths#1307
jaso0n0818 wants to merge 2 commits into
JSONbored:mainfrom
jaso0n0818:feat/signals-redaction-system-paths

Conversation

@jaso0n0818

Copy link
Copy Markdown
Contributor

Summary

Extends the shared PUBLIC_UNSAFE_PATTERN in redaction.ts so public GitHub surfaces also redact common Linux /var/ and Windows Program Files install paths (#542 follow-up).

New blocked paths:

  • /var/... (e.g. /var/log/app.log)
  • C:\Program Files\... style Windows install directories

Test plan

Expand the shared PUBLIC_UNSAFE_PATTERN so maintainer-facing copy cannot
leak common Linux /var or Windows Program Files filesystem paths (JSONbored#542).

Co-authored-by: Cursor <cursoragent@cursor.com>
@jaso0n0818
jaso0n0818 requested a review from JSONbored as a code owner June 25, 2026 04:28
@dosubot dosubot Bot added the size:XS label Jun 25, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.33%. Comparing base (6138b9e) to head (7ad74a9).
⚠️ Report is 42 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1307   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files         192      192           
  Lines       20750    20750           
  Branches     7500     7500           
=======================================
  Hits        19783    19783           
  Misses        383      383           
  Partials      584      584           
Files with missing lines Coverage Δ
src/signals/redaction.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored JSONbored added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 26, 2026

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: CLOSE — base conflict · hands-off, owner executes.

Correct/minimal redaction extension, but CONFLICTING.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants