Skip to content

feat(signals): delegate isTestFile to test-evidence isTestPath - #1306

Merged
JSONbored merged 4 commits into
JSONbored:mainfrom
jaso0n0818:feat/signals-testfile-delegate
Jun 26, 2026
Merged

feat(signals): delegate isTestFile to test-evidence isTestPath#1306
JSONbored merged 4 commits into
JSONbored:mainfrom
jaso0n0818:feat/signals-testfile-delegate

Conversation

@jaso0n0818

Copy link
Copy Markdown
Contributor

Summary

Delegates isTestFile in local-branch.ts to isTestPath from test-evidence.ts so local scoring, slop, and contributor evidence share one test-path matcher (#561 / #1046 follow-up, extends #947).

Behavior:

  • Removes the duplicated regex block in isTestFile
  • Keeps e2e/integration/playwright/cypress/snapshot paths recognized consistently across surfaces

Test plan

Route local-branch scoring through the shared test path matcher so
slop classification and branch previews never drift when test-evidence
gains new conventions (JSONbored#1046).

Co-authored-by: Cursor <cursoragent@cursor.com>
@jaso0n0818
jaso0n0818 requested a review from JSONbored as a code owner June 25, 2026 04:28
@dosubot dosubot Bot added the size:S label Jun 25, 2026
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.42%. Comparing base (fb935f4) to head (1778b95).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
- Coverage   95.42%   95.42%   -0.01%     
==========================================
  Files         193      193              
  Lines       21020    21019       -1     
  Branches     7614     7613       -1     
==========================================
- Hits        20058    20057       -1     
  Misses        383      383              
  Partials      579      579              
Files with missing lines Coverage Δ
src/signals/local-branch.ts 97.19% <100.00%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 26, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen: ✅ low-risk signal hygiene. Verdict: MERGE-on-merit · hands-off, owner executes. Verified byte-identical bodies → behavior-preserving DRY consolidation, kills a drift hazard. Green.

@dosubot dosubot Bot added the lgtm label Jun 26, 2026
@JSONbored
JSONbored merged commit 7227f27 into JSONbored:main Jun 26, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants