fix(migrations): renumber orb_webhook_events 0063 → 0064 (collision) - #1300
Merged
Conversation
#1293 (orb webhook receiver) and the re-gate sweep PR both grabbed migration number 0063, so main shipped a duplicate 0063_*.sql and db:migrations:check fails for every branch off main. Renumber the newest (orb_webhook_events, which uses CREATE TABLE/INDEX IF NOT EXISTS and is not yet deployed) to the next free number; the sweep marker keeps 0063.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 179 179
Lines 20124 20124
Branches 7239 7239
=======================================
Hits 19147 19147
Misses 386 386
Partials 591 591 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1293 and the re-gate sweep PR each grabbed migration 0063, so
mainnow has a duplicate (0063_orb_webhook_events.sql+0063_sweep_fanout_marker.sql) anddb:migrations:checkfails on every branch off main. Renumber the newest —orb_webhook_events(pureCREATE TABLE/INDEX IF NOT EXISTS, not yet deployed since the Orb app isn't live) — to the next free number0064; the sweep marker keeps0063.File rename only — the migration runner globs
migrations/*.sql, no code references the number.Validation
db:migrations:check→66 migrations OK — contiguous 0001..0064 … Next free: 0065