feat(scoring): wire contributor validity floors into score preview (#808) - #1284
Conversation
…SONbored#808) Mirror upstream merged-PR and issue-discovery eligibility gates in preview, local branch wiring, scenario projections, and API/OpenAPI schemas. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1284 +/- ##
=======================================
Coverage 95.40% 95.41%
=======================================
Files 193 193
Lines 20973 21006 +33
Branches 7581 7609 +28
=======================================
+ Hits 20010 20043 +33
Misses 383 383
Partials 580 580
🚀 New features to boost your workflow:
|
…ONbored#808) Only apply issue-discovery validity when linkedIssueMode is active, and bump local-branch fixtures to established contributor history so existing scenario tests stay valid under the merged-PR floor. Co-authored-by: Cursor <cursoragent@cursor.com>
…bored#808) Remove dead nullish-coalescing branches in gate blockers/deltas and add coverage for contributor-history wiring, public blocker text, and actions. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@JSONbored |
Please note, if you comment/message for reviews in the future, it's a +5 day wait to get reviewed. Too many people keep bugging me to review - I know the PRs need to be reviewed and I'll review them when time permits :) |
JSONbored
left a comment
There was a problem hiding this comment.
Confirmed net-new on current main — #835 wired the issue-discovery constants into the engine; this closes the preview-side gap so a miner's projection actually reflects the validity floors. Conservative "unknown ⇒ don't gate" semantics, mirrored as blocker + gate-delta + scenario, OpenAPI regenerated. On the active preview-accuracy line, real value, low maintenance. Merge. (Minor: it links the now-closed #808; the work itself is the legitimate follow-up.)
Summary
Completes the remaining #808 contributor validity floors by wiring upstream eligibility gates into score preview:
MIN_VALID_MERGED_PRS): zeroes the estimate when repo-level merged count is known and below the floor; inferred from contributor evidence when omitted.MIN_VALID_SOLVED_ISSUES,MIN_ISSUE_CREDIBILITY): applied when issue-discovery is relevant (non-zeroissueDiscoveryShareor linked-issue mode); skipped when history is unknown.mergedPullRequests,validSolvedIssues, andissueCredibilityfrom outcome history.cleanGates,afterPendingMerges,bestReasonableCase) project history cleanup; gate deltas and public blocker text updated.Fixes #808 (partial — completes contributor validity wiring alongside prior open-issue spam and test-file weight work).
Test plan
npm run test:ci(or targetedtest/unit/scoring.test.ts+test/unit/local-branch.test.ts)merged_pr_history_floorbestReasonableCaseandafterPendingMergesscenario projections