feat(review): high-signal reviews + visible Gate re-run on checkbox - #1091
Merged
Conversation
Two review-quality fixes after the blockers/nits depth port went live:
1. Noise: the deep review over-listed findings (e.g. 9 blockers, many the same
'doesn't handle empty array / catch errors' pattern repeated per function, plus
a 'why blocked' that repeated every blocker). Tune for high signal:
- prompt: be SELECTIVE (~3 blockers / ~5 nits max), DEDUPLICATE recurring issues,
and tighten severity (defensive 'should handle X' hardening is a NIT, not a
blocker, unless a real input will actually fail).
- caps: parse 12->6; rendered blockers 8->3, nits 12->5.
- consensus defect: the Gate's 'why blocked' cites only the PRIMARY blocker, not
the whole list joined together.
2. Re-run visibility (B): clicking 'Re-run Gittensory review' now flips the Gittensory
Gate check to in_progress before the re-review runs, so it visibly goes running ->
concluded like a real CI step (fail-safe; resolves the same run by name+headSha).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1091 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 153 153
Lines 18540 18542 +2
Branches 6705 6705
=======================================
+ Hits 17570 17572 +2
Misses 418 418
Partials 552 552 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the blockers/nits depth port (#1089), which is now live and producing real finding-by-finding reviews (e.g. metagraphed #1528 correctly closed on a genuine missing-import ReferenceError).
1. Noise → high signal
The deep review over-listed: ~9 blockers (many the same 'doesn't handle empty array / catch errors' pattern repeated per function), ~12 nits, and a 'why blocked' that repeated every blocker. Tuned:
2. Re-run visibility (task B)
Clicking 'Re-run Gittensory review' now flips the Gittensory Gate check to in_progress before the re-review runs, so it visibly goes running → concluded like a real CI step (fail-safe; resolves the same run by name+headSha, no duplicate).
Full suite green (3485). Internal to the review path; gate/comment contracts unchanged.