Skip to content

feat(review): never auto-close automation-bot PRs (accumulator/dependency) - #1055

Merged
JSONbored merged 1 commit into
mainfrom
feat/protect-automation-from-autoclose
Jun 22, 2026
Merged

feat(review): never auto-close automation-bot PRs (accumulator/dependency)#1055
JSONbored merged 1 commit into
mainfrom
feat/protect-automation-from-autoclose

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

What

Extends the auto-maintain close guard so PRs authored by maintainer-managed automation accounts (github-actions[bot], dependabot[bot], renovate[bot]) are never auto-closed.

A recurring accumulator — e.g. github-actions[bot]'s automation/readme-refresh (the generated catalog index) — or a dependency PR must not be killed by a duplicate/slop noise heuristic; the maintainer owns its lifecycle. reviewbot wrongly auto-closed exactly this accumulator (awesome-claude #4192); this prevents gittensory from repeating it now that auto-close is live.

Mirrors the existing owner-PR guard: blocks only close, never merge — these PRs still auto-merge when clean + passing.

  • isProtectedAutomationAuthor() + the close-branch guard in agent-actions.ts, wired from processors.ts.
  • Tests: automation-bot PR not closed (even with high slop + duplicate), still auto-merges when clean; helper unit tests (case-insensitive, null-safe).

Closes Task 8 of epic #983. Typecheck clean; full unit suite (3315) green.

…ency)

Extends the auto-maintain close guard: PRs authored by maintainer-managed automation accounts (github-actions[bot], dependabot[bot], renovate[bot]) are never auto-closed. A recurring accumulator like github-actions[bot]'s automation/readme-refresh, or a dependency PR, must not be killed by a duplicate/slop noise heuristic — the maintainer owns its lifecycle (reviewbot wrongly closed such an accumulator, awesome-claude #4192). They remain eligible for auto-merge when clean + passing, same as the owner-PR guard. Adds isProtectedAutomationAuthor + tests. Part of epic #983.
@dosubot dosubot Bot added the size:S label Jun 22, 2026
@superagent-security

superagent-security Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@ghost

ghost commented Jun 22, 2026

Copy link
Copy Markdown

Note

🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦

💡 Gittensory review — advisory only

0 files · no blockers · readiness 0/100

💡 Advisory only — no action taken

Signal Result Evidence
Code review ✅ No blockers synthesized
Gate result ⚠️ Skipped #1055 is no longer open.

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.75%. Comparing base (2288644) to head (87825c7).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1055   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files         143      143           
  Lines       17580    17583    +3     
  Branches     6364     6365    +1     
=======================================
+ Hits        17010    17013    +3     
  Misses        108      108           
  Partials      462      462           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored
JSONbored merged commit c147204 into main Jun 22, 2026
19 checks passed
@JSONbored
JSONbored deleted the feat/protect-automation-from-autoclose branch June 22, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant