feat(review): unified PR comment parity — collapsibles + CI chips + reviewer count - #1051
Merged
Conversation
…iewer count Wire the three args the unified-comment renderer/bridge already supported but the processor never passed: - extraCollapsibles: public-safe Signal definitions / Review context / Contributor next steps / Review details, extracted from the legacy buildPublicPrIntelligenceComment (NEVER the private 'Maintainer notes'). - reviewerCount: surfaced from runGittensoryAiReview (reviewsForNotes.length). - mergeReadiness: CI chips derived from listCheckSummaries + pr.mergeableState. Shared the legacy public-findings filter into publicSafePreflightFindings() so the legacy builder and the new collapsibles are single-source; flag-OFF output (buildPublicPrIntelligenceComment) verified byte-identical. Adds a parity test. Part of #1011 / epic #983.
|
Note 🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦 💡 Gittensory review — advisory only
💡 Advisory only — no action taken
💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
ghost
added
the
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
===========================================
+ Coverage 71.78% 96.76% +24.97%
===========================================
Files 141 141
Lines 17506 17548 +42
Branches 6334 6351 +17
===========================================
+ Hits 12567 16980 +4413
+ Misses 3785 108 -3677
+ Partials 1154 460 -694 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JSONbored
added a commit
that referenced
this pull request
Jun 22, 2026
…ke timers) The test drove an async flow — real WebCrypto token-decrypt + async D1/fetch interleaved with one setTimeout(sleep 3000) — via a fake-timer pump loop. Under CI full-shard coverage load the real macrotask lagged the microtask flush the pump relied on, so the scheduled sleep was never fired and the test HUNG → 15s timeout (the CI-only flake that blocked #1050/#1051/#1052/#1056). Fix: drop fake timers entirely. Mock setTimeout so the sleep(3000) backoff fires on a real 0ms tick, then await processSubmitDraft directly — the flow runs to completion on the real event loop (probe 404 → instant backoff → probe 200 → open PR) with no pump, no race, no real 3s wait, no weakened assertions. Verified stable across 6+ consecutive plain + coverage runs locally.
JSONbored
added a commit
that referenced
this pull request
Jun 22, 2026
…ke timers) (#1057) The test drove an async flow — real WebCrypto token-decrypt + async D1/fetch interleaved with one setTimeout(sleep 3000) — via a fake-timer pump loop. Under CI full-shard coverage load the real macrotask lagged the microtask flush the pump relied on, so the scheduled sleep was never fired and the test HUNG → 15s timeout (the CI-only flake that blocked #1050/#1051/#1052/#1056). Fix: drop fake timers entirely. Mock setTimeout so the sleep(3000) backoff fires on a real 0ms tick, then await processSubmitDraft directly — the flow runs to completion on the real event loop (probe 404 → instant backoff → probe 200 → open PR) with no pump, no race, no real 3s wait, no weakened assertions. Verified stable across 6+ consecutive plain + coverage runs locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes the converged unified PR comment (#1011) by passing the three args the renderer + bridge already supported but
processors.tsnever wired:buildPublicPrIntelligenceComment: Signal definitions, Review context, Contributor next steps, Review details. The private "Maintainer notes" section is never included (asserted by test).runGittensoryAiReview(reviewsForNotes.length); drives the "N AI reviewers" chip + the code-review evidence row.listCheckSummaries(success→passed, failure/timed_out/cancelled/action_required→failed, else unverified) +mergeStateLabelfrompr.mergeableState.Safety / parity
publicSafePreflightFindings()so the legacy builder and the new collapsibles are single-source.buildPublicPrIntelligenceComment(captured HEAD vs working-tree output, same fixtures, diff empty).unified-comment-parity.test.tsasserts the flag-ON body contains the public sections and never contains "Maintainer notes"; legacy panel still renders it inline.Typecheck clean; full unit suite (3292 tests) green. Part of #1011 / convergence epic #983.