Skip to content

test(signals): fix drifted queue-health fixture dates (unblocks main CI) - #1003

Merged
JSONbored merged 1 commit into
mainfrom
fix/signals-v2-time-bomb-fixture
Jun 22, 2026
Merged

test(signals): fix drifted queue-health fixture dates (unblocks main CI)#1003
JSONbored merged 1 commit into
mainfrom
fix/signals-v2-time-bomb-fixture

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Problem

test (2) + the validate aggregator are failing on main and on every open PR (#985, #996, #997). Root cause is a single time-bomb test:

test/unit/signals-v2.test.ts > v2 signal builders > adds queue age buckets and likely-reviewable counts
AssertionError: expected 0 to be greater than or equal to 1

The shared pullRequests fixture used fixed updatedAt dates. PR #10 (2026-05-23) was chosen to be "recent" but, as of 2026-06-22, it is exactly 30 days old — crossing the < 30 days likely-reviewable cutoff in buildQueueHealth, so likelyReviewablePullRequests dropped to 0.

Fix

Anchor the shared fixture's PR ages relative to now (isoDaysAgo(20) / isoDaysAgo(82)) so the age-bucket / reviewability windows never drift again. Test-only change; all 31 tests in the file pass.

This unblocks test (2) + validate for main and the three open PRs.

The shared signals-v2 pull-request fixture used fixed updatedAt dates. PR #10
('2026-05-23') crossed the 30-day likely-reviewable cutoff as real time advanced,
so 'adds queue age buckets and likely-reviewable counts' began failing (likelyReviewable
0, expected >= 1) — breaking test shard 2 + the validate aggregator on main and every
open PR. Anchor the fixture ages relative to now so the windows never drift.
@dosubot dosubot Bot added the size:XS label Jun 22, 2026
@ghost

ghost commented Jun 22, 2026

Copy link
Copy Markdown

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #1003 is no longer open. No action.

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost added the gittensory:reviewed label Jun 22, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored
JSONbored merged commit 3b0af4a into main Jun 22, 2026
17 checks passed
@JSONbored
JSONbored deleted the fix/signals-v2-time-bomb-fixture branch June 22, 2026 08:17
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.61%. Comparing base (363c0fb) to head (282f97a).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1003   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         110      110           
  Lines       15079    15079           
  Branches     5451     5451           
=======================================
  Hits        14569    14569           
  Misses        106      106           
  Partials      404      404           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghost ghost added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant