Skip to content

review: normalizeResolveFindingRef is implemented twice, leaving src/github/resolve-command.ts dead #9572

Description

@JSONbored

Found while triaging #9553's unused-symbol list, via dead-source-files:check.

src/github/resolve-command.ts had no production importer — only its own test. Not because the function is unused, but because src/review/review-memory-wire.ts carried a second, byte-identical copy of normalizeResolveFindingRef, regex (/^[a-z][a-z0-9_]{0,199}$/) included, and that copy is the one the resolve handler imports.

So there were two independent implementations of the same public-safety validation — the one that decides whether a @loopover resolve <finding-id> argument is a safe finding code — free to drift apart, with the canonical module kept alive only by its own test.

This is precisely the shape #9492's dead-source check was built to catch (the issue-rag-wire.ts pattern): a module that coverage reports as green the whole time, because a dead module's own test exercises it perfectly well.

Fix: re-export from the canonical module instead of re-implementing, so there is one definition and src/github/resolve-command.ts is genuinely wired.

Metadata

Metadata

Assignees

Labels

maintainer-onlyOwner-only work — yields no Gittensor points.orbGittensory Orb related - maintainer self-hosting analytics.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions