Skip to content

fix(orb): stale "blocked on #6477" comments in federated-bundle.ts/federated-collector.ts -- #6480 already shipped #8878

Description

@JSONbored

⚠️ Definition of Done: this issue must be completed in full, in a single PR. Do not split this
work across multiple PRs, and do not defer any Deliverable below to a follow-up issue. A PR that
satisfies only some of the Deliverables, stubs a required test, or leaves a checkbox
partially-done does NOT resolve this issue and will be closed.

Context

src/orb/federated-bundle.ts:165-169 says "#6480 (the import side) is explicitly blocked on #6477 for exactly that reason" and src/orb/federated-collector.ts:8-12,167 repeats "that is #6480's job, and #6480 is blocked on #6477 (the key-trust/anti-poisoning design)". But src/orb/federated-import.ts (git log: 729254ad0 feat(orb): trust-gate inbound federated bundles per the #6477 key-trust design (#6649)) fully implements #6480 using an operator-supplied peerKeys allowlist, and src/orb/federated-benchmark.ts:2-4 explicitly lists all three stages -- export/transport/import -- as "already-shipped".

Requirements

Update both stale comments to reflect that #6480 shipped (allowlist-based key trust, no PKI/reputation system, per #6477's ratified design) instead of describing it as still blocked/not-yet-built.

Deliverables

All of the above Deliverables are required in the same PR unless the deliverable text itself states otherwise.

Test Coverage Requirements

Docs/comment-only change -- no test coverage requirement, but the PR must cite src/orb/federated-import.ts's real implementation as the source of truth for the corrected comment text.

Expected Outcome

Comments in federated-bundle.ts/federated-collector.ts accurately describe the current, shipped state of the federated-import trust mechanism instead of describing it as still blocked.

Links & Resources

  • src/orb/federated-bundle.ts:165-169
  • src/orb/federated-collector.ts:8-12,167
  • src/orb/federated-import.ts
  • src/orb/federated-benchmark.ts:2-4

Metadata

Metadata

Assignees

No one assigned

    Labels

    gittensor:bugGittensor-scored bug fix — scores a 0.05x multiplier.help wantedExtra attention is needed

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions