fix(engine): protect the real post-#6203 autonomy/guardrail-config paths, not just their src/ shims - #8128
Merged
Conversation
…ths, not just their src/ shims src/settings/autonomy.ts and src/review/guardrail-config.ts are now 5-line re-export shims after #4879/#6203 moved the real logic into @loopover/engine. ENGINE_DECISION_GUARDRAIL_GLOBS still only listed the shim paths, so a PR editing the real autonomy deny-by-default dial, or silently narrowing this guardrail list itself, would touch only the packages/loopover-engine files and never trip the manual- review hold it should. Adds the real packages/loopover-engine paths alongside the existing shim entries. Closes #8012.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | 7080a7a | Commit Preview URL Branch Preview URL |
Jul 22 2026, 11:54 PM |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8128 +/- ##
==========================================
- Coverage 92.02% 92.02% -0.01%
==========================================
Files 760 760
Lines 77394 77394
Branches 23392 23392
==========================================
- Hits 71225 71221 -4
Misses 5061 5061
- Partials 1108 1112 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENGINE_DECISION_GUARDRAIL_GLOBS(packages/loopover-engine/src/review/guardrail-config.ts) exists so a PR touching a safety-decision file is forced to manual review — never auto-merged or auto-closed (ported from reviewbot core to prevent an incident class where an auto-merged PR quietly weakened the gate itself).src/settings/autonomy.tsandsrc/review/guardrail-config.ts— both now confirmed 5-line re-export shims (export * from "../../packages/loopover-engine/src/...") after Finish thesettings/slice extraction #4879/chore(review): converge 9 hand-duplicated src/review/ files onto their @loopover/engine shims #6203 moved the real logic into@loopover/engine. The real, substantive files never appeared in the guardrail list at all.ENGINE_DECISION_GUARDRAIL_GLOBS/DEFAULT_HARD_GUARDRAIL_GLOBSitself to quietly remove entries, could touch only the real engine-package file and never trip the guardrail hold it should — verified this was a real gap via a full-repo grep confirming no other glob list coverspackages/loopover-engine/src/**.packages/loopover-engine/src/...paths alongside the existing shim entries (kept, since they're still real if thin files).Closes #8012.
Test plan
test/unit/guardrail-config.test.ts: both real paths are present inENGINE_DECISION_GUARDRAIL_GLOBS, and a PR touching only the real path (never the shim) tripsisGuardrailHitagainstDEFAULT_HARD_GUARDRAIL_GLOBS.isGuardrailHitreturnsfalsefor the real paths pre-fix), then restored the fix and confirmed green.npm run build --workspace @loopover/enginenpx tsc --noEmitguardrail-config,change-guardrail,agent-guardrail-paths,predicted-gate-engine-coverage,queue-3,processors-public-comment-merge-facts) — 225/225 passingnpm run test --workspace @loopover/engine(648/648 passing)npm run engine-parity:drift-check— clean, not one of the 5 hand-duplicated twin-pair files