fix: correct four stale 'improvementSignal not wired yet' comments - #6691
Conversation
improvementSignal (epic JSONbored#4737) shipped and its sub-issues (JSONbored#4738-JSONbored#4746) all closed, but four module/doc comments still described it as inert/test-only. src/queue/processors.ts is now its real caller (convergedFeatureActive + buildStructuralImprovementAssessment, gated on the resolved value). Correct the headers in improvement-signal-wire.ts and signals/improvement.ts, the improvementSignal field doc in services/ai-review.ts, and the CONVERGED_FEATURE_KEYS comment in engine/focus-manifest.ts to match. Comment-only; no runtime behavior, exports, types, or signatures change (the still-accurate sub-claims, e.g. improvement.ts's complexityDeltas note, are left as-is). Closes JSONbored#6608.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6691 +/- ##
==========================================
- Coverage 93.65% 93.65% -0.01%
==========================================
Files 682 682
Lines 68118 68112 -6
Branches 18711 18708 -3
==========================================
- Hits 63795 63788 -7
Misses 3347 3347
- Partials 976 977 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-16 19:45:17 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
improvementSignal(epic #4737, config-as-code foundation #4738) is a fully wired, live converged feature — its sub-issues #4738–#4746 all shipped and closed — but four comments still describe it as inert/never-called, misleading anyone reading the code.src/queue/processors.tsis now its real caller:convergedFeatureActive(env, repoFullName, "improvementSignal")at :7821, passed asimprovementSignalinto AI-review options at :9361, and gating a realbuildStructuralImprovementAssessmentcall at :10062-10068.This corrects the four stale comments:
src/review/improvement-signal-wire.tsheader ("nothing calls resolveConvergedFeature … outside this feature's own tests").src/signals/improvement.tsheader ("consumed only by its own tests until the panel-surfacing sub-issue wires a caller").src/services/ai-review.tsimprovementSignalfield doc ("the only reachable value until a caller starts resolving the feature").packages/loopover-engine/src/focus-manifest.tscomment aboveCONVERGED_FEATURE_KEYS("no tier reads the resolved value yet").Comment-only — no runtime behavior, exports, types, or signatures change; still-accurate sub-claims (e.g.
improvement.ts'scomplexityDeltas/duplicationDeltasno-live-source note) are left untouched. Every changed line is a comment (verified), so the Codecov patch gate does not apply. Engine build + engine-parity script test pass unchanged.Closes #6608.