Skip to content

review: collapse the 9-row signal table into decision-driver chips + one advisory fold #6067

Description

@JSONbored

Part of #6065.

Problem

signalTable() (src/review/unified-comment.ts:571) always renders a Signal/Result/Evidence table with a synthetic "Code review" row plus up to 8 more from buildPublicPrPanelSignalRows() (packages/loopover-engine/src/signals/engine.ts:4658). Of those rows, only "Code review" and "Gate result" are ever decision-authoritative -- the rest (Related work, Change scope, Validation posture, Contributor workload, Contributor context, Improvement) are explicitly advisory per their own Evidence/Action text (e.g. the Improvement row's Evidence is hardcoded "Advisory only -- never blocks merge.", engine.ts:4829). The table renders unconditionally and is the single largest always-visible block in the comment, yet most of it is never used to make a decision.

Proposed fix

  • Replace the always-rendered table with a compact "Decision drivers" chip strip containing only rows that can move the verdict (Code review, Gate result, CI).
  • Fold every advisory-only row into ONE collapsed "Context & advisory signals" <details> block (reuse the existing table rendering for its contents, just move it behind a fold), consolidated with the existing Nits and "Flagged checks (non-blocking)" collapsibles rather than keeping them as separate folds.
  • review.fields.<key> show/hide toggles (packages/loopover-engine/src/focus-manifest.ts, REVIEW_FIELD_KEYS) must keep working per-row inside the new fold -- this is a rendering change only, not a config-surface change.
  • Keep byte-identical behavior when review.comment_verbosity: quiet already trims decorative detail.

Files

  • src/review/unified-comment.ts (signalTable, renderUnifiedReviewComment)
  • src/review/unified-comment-bridge.ts
  • packages/loopover-engine/src/signals/engine.ts (buildPublicPrPanelSignalRows / buildImprovementSignalRow -- may need a "gates the verdict" marker on each row)
  • relevant unit tests (signals-coverage.test.ts, unified-comment tests)

Metadata

Metadata

Assignees

Labels

maintainer-onlyOwner-only work — yields no Gittensor points.orbGittensory Orb related - maintainer self-hosting analytics.roadmapOn the Wave-2 agent-layer roadmap board (project 9)

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions