-
-
Notifications
You must be signed in to change notification settings - Fork 90
Converge the scoring/rules twins #4881
Copy link
Copy link
Closed
Labels
gittensor:featureGittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.help wantedExtra attention is neededExtra attention is needed
Milestone
Description
Metadata
Metadata
Assignees
Labels
gittensor:featureGittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.help wantedExtra attention is neededExtra attention is needed
Problem: The gate-decision advisory logic exists as two hand-maintained "twin" files today — one in
src/, one already ingittensory-engine— and they're deliberately allowed to structurally diverge, specifically so the engine's copy doesn't have to pull the entire, much larger signals-engine file into the miner's own dependency graph. Whether to converge these to one real source, or keep them intentionally separate, is a real decision, not a mechanical move.Area: ORB / gittensory-engine
Proposal: Evaluate each twin pair individually. For any pair where divergence no longer serves a real purpose, converge to one source with a shim. For the one pair explicitly documented as deliberately divergent, either keep it that way (documenting why, clearly, for future contributors) or design a way to satisfy both constraints (e.g. a shared type-only import that doesn't pull the larger file's implementation along with it).
Deliverables:
Acceptance criteria:
Boundaries: