Skip to content

feat(commands): @gittensory resolve command — parse + classify + mark a review finding resolved (dispatch scaffold) #2166

Description

@JSONbored

Wire the @gittensory resolve [] command: a maintainer marks a posted review finding as resolved so it stops re-surfacing. The unified comment + inline-comments subsystem already renders findings (src/review/unified-comment.ts, src/review/inline-comments.ts) and there is a review-thread findings module (src/review/review-thread-findings.ts). Contributor scope = the parser recognition + classifier + authorization + recording a github_app.finding_resolved audit event keyed to the finding id/thread + tests. The actual suppression semantics that feed back into a future review pass are maintainer-owned; this bounty stops at recording the resolution and confirming it.

Deliverables

  • Add maybeProcessResolveCommand: parse the optional finding argument, classify → evaluateCommandAuthorization("resolve") → record github_app.finding_resolved with the finding id + repo#pr
  • Handle both forms: @gittensory resolve (whole-PR ack) and @gittensory resolve <finding-id> (single finding) — validate/normalize the id argument
  • Post a public-safe confirmation naming what was marked resolved
  • Reuse the shared preamble/classifier + gate-override recording shape for skip/denied/completed
  • Unit tests: with/without a finding id, authorized→recorded, unauthorized→denied, skips, malformed id rejected (both branches of the id-present ternary)

References

  • src/review/review-thread-findings.ts
  • src/review/unified-comment.ts:183
  • src/review/inline-comments.ts
  • src/queue/processors.ts:5977 (handler pattern)
  • #1960

Part of #1960.


size: S · held for later release (gittensor:feature once activated)

Metadata

Metadata

Assignees

No one assigned

    Labels

    gittensor:featureGittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

    Projects

    Status
    Done

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions