Skip to content

feat(review): review.suggestions config toggle (default off) gating suggested-change blocks #2142

Description

@JSONbored

Add a per-repo review.suggestions manifest toggle (default OFF) that gates whether ```suggestion blocks are emitted, layered on top of the existing inline-comment three-gate. Mirrors the shouldRequestInlineFindings toggle pattern so suggestions never surface unless a maintainer opts in.

Deliverables

  • Add a pure shouldRenderSuggestions(inlineEnabled, manifestSuggestionsToggle) helper in src/review/inline-comments.ts alongside shouldRequestInlineFindings (src/review/inline-comments.ts:29)
  • Thread the resolved boolean into formatInlineBody/selectInlineComments so a suggestion block is only appended when both inline-comments AND suggestions are on
  • Default OFF: suggestions never render unless the manifest toggle is true
  • Tests: toggle on+inline on → suggestion; toggle off → plain comment; inline off → nothing (both branches of the AND)

References

  • src/review/inline-comments.ts:21
  • src/review/inline-comments.ts:29
  • part of #1956

Part of #1956.


size: XS · held for later release (gittensor:bug once activated)

Metadata

Metadata

Assignees

Labels

maintainer-onlyOwner-only work — yields no Gittensor points.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions