Skip to content

feat(review): skip auto-review for bot/ignored authors via review.auto_review.ignore_authors globs #2060

Description

@JSONbored

Part of #1954. Add review.auto_review.ignore_authors (glob list, e.g. *[bot], dependabot) so operators skip named bots/authors beyond the existing hard bot_author check in decidePublicSurface (src/signals/settings-preview.ts:87). Deterministic glob match on the author login; default empty ⇒ no extra skips.

Deliverables

  • Parse ignore_authors as a bounded, deduped string glob list in parseReviewConfig (src/signals/focus-manifest.ts:653) with a MAX cap (mirror MAX_PATH_INSTRUCTIONS discipline, src/signals/focus-manifest.ts:175); serialize in reviewConfigToJson
  • Add an author-glob branch to decideReviewEligibility (src/review/review-eligibility.ts) reusing the manifest glob matcher (matchesManifestPath-style) or a small login-glob helper; skipReason="ignored_author"
  • Wire at maybePublishPrPublicSurface (src/queue/processors.ts:4533) using the already-resolved author login (pr.authorLogin)
  • Unit tests: matching glob ⇒ skip, non-match ⇒ eligible, empty list ⇒ eligible, cap enforced, case handling; 97% branch

References

  • src/signals/settings-preview.ts:87
  • src/queue/processors.ts:4551
  • src/signals/focus-manifest.ts:175
  • #1954

Part of #1954.


size: S · gittensor:feature

Metadata

Metadata

Assignees

No one assigned

    Labels

    gittensor:featureGittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.help wantedExtra attention is needed

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions