test(config): lock in includeMaintainerAuthors manifest resolver parity

[RealDiligent]

Summary

Closes the remaining deliverable for #2052: resolver coverage for settings.includeMaintainerAuthors.

The parser key, settingsOverrideToJson round-trip, and .gittensory.yml.example documentation were already present on main; this PR adds the missing unit tests proving manifest override wins over DB, unset falls back, and wrong-type values warn.

Closes #2052

Validation

npm test -- test/unit/focus-manifest.test.ts

Focused test: wires settings.includeMaintainerAuthors into the manifest parser and resolver (#2052) — 521 tests in file pass.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[gittensory-orb]

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review result - approve/merge recommended

_{Review updated: 2026-07-07 15:08:00 UTC}

1 file · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This is a test-only PR that adds one consolidated test case exercising settings.includeMaintainerAuthors through parseFocusManifest, resolveEffectiveSettings, and the settingsOverrideToJson round-trip. The diff itself makes no src/** changes — it mirrors the exact pattern of the adjacent badgeEnabled and publicQualityMetrics tests already in the file, using real (not fabricated) production functions, and the PR correctly links to and closes the eligible open issue #2052 which the description says was left with a coverage gap. CI is green and the change is narrow, low-risk, and additive.

Nits — 4 non-blocking

• test/unit/focus-manifest.test.ts: the new test bundles five distinct assertions (valid-true, valid-false, invalid-type, override-wins, no-override-fallback, round-trip) into a single `it` block — splitting into 2-3 named cases would make a future failure point directly at which scenario broke instead of requiring a stack-trace read.
• test/unit/focus-manifest.test.ts: the `as unknown as RepositorySettings` casts used for the DB stub objects would be cleaner with a shared minimal-settings test fixture/factory if this pattern repeats across many tests in the file, but matches existing sibling tests so it's consistent, not a regression.
• Consider consolidating the `as unknown as RepositorySettings` casting pattern into a small test helper if it recurs across many settings-flag tests in this file, to reduce boilerplate.
• If there's an existing convention in this file of one `it` per settings flag, keep this test but note it's slightly denser (5 assertions) than the ~2-3 in siblings like badgeEnabled — worth a quick split for future debuggability.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#2052
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 248 registered-repo PR(s), 73 merged, 0 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	RealDiligent; Gittensor profile; 248 PR(s), 0 issue(s).
Gate result	✅ Passing	No configured blocker found.

Review context

• Author: RealDiligent
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: JavaScript, Ruby, Svelte, TypeScript, Cuda, Markdown
• Official Gittensor activity: 248 PR(s), 0 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.58%. Comparing base (590d52c) to head (7b32f08).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4051   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files         379      379           
  Lines       35530    35530           
  Branches    13033    13033           
=======================================
  Hits        33250    33250           
  Misses       1618     1618           
  Partials      662      662           

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gittensory-orb]

Gittensory approves — the gate is satisfied and CI is green.