fix(miner): treat null readEvents since filter as unscoped#3016
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-04 08:59:30 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3016 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 260 260
Lines 28689 28689
Branches 10437 10437
=======================================
Hits 27560 27560
Misses 493 493
Partials 636 636 🚀 New features to boost your workflow:
|
Summary
readEvents({ since: null })as an unscoped poll, matching how null repo filters already behave.invalid_sincewhen callers omit a seq cursor vianull.Scope
type(scope): short summaryConventional Commit format.readEventsfiltering only — no unrelated miner CLI or UI changes.Validation
npm run test:cilocally — CI will run the full gate on push.sincereturning all events.Safety
UI Evidence
Not applicable — miner library only.
Notes
Follow-up to #2897 and #2955 — completes nullish read-filter parity for the event ledger (#2290).