fix(miner): treat null listPlans status filter as unscoped#2980
Conversation
listPlans no longer throws invalid_status on a null status filter; null and omitted filters both return all plans. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-04 08:14:49 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 1 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2980 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 259 259
Lines 28663 28663
Branches 10431 10431
=======================================
Hits 27536 27536
Misses 490 490
Partials 637 637 🚀 New features to boost your workflow:
|
Summary
statusfilter inlistPlansas unscoped, matching claim-ledger and event-ledger read semantics.{ status: null }from throwinginvalid_statuswhen callers mean "all plans".Scope
type(scope): short summaryConventional Commit format.Validation
npm run test:cilocally — CI will run the full gate on push.Safety
UI Evidence
Not applicable — miner library only.
Notes
Follow-up consistency fix after #2978 null list-filter normalization in the claim ledger.