docs(config): correct gate knob semantics in .gittensory.yml.example#2901
Conversation
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-04 05:22:11 UTC
⏸️ Suggested Action - Manual Review
Review summary Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
a506653 to
21ce392
Compare
Motivation
.gittensory.ymltext introduced wording that does not match the runtime semantics of several enforcement-sensitive gate knobs, which could mislead maintainers into unsafe expectations.gate.dryRunwas presented as suppressing enforcement, andgate.aiReview.closeConfidencewas described as preventing blocks below the floor.Description
.gittensory.yml.exampleto clarify the Oversized-PR gate: the manual-review HOLD triggers when EITHER the changed-file count or changed-line count exceeds its threshold, matching the implemented logic (src/rules/advisory.ts).gate.dryRunto clarify it is a check/comment preview (the posted check may show a would-be stricter verdict) and does not disable downstream merge/close planning for failures already enforced by the gate.gate.aiReview.closeConfidenceto document that the value is recorded for cache/calibration context and does not downgrade block-mode AI defects into advisory-only, matching the evaluator logic..gittensory.yml.exampleand preserves existing behavior and tests.Testing
git diff --checkwhich reported no whitespace/conflict issues and is clean.npx vitest run test/unit/focus-manifest.test.ts --testNamePattern "parses \\.gittensory\\.yml\\.example", which passed and confirmed the example file parses with zero warnings and the parser round-trips the documented knobs.npm run test:ci, andnpm audit --audit-level=moderate, but those runs were blocked in this environment due to external network/setup failures (actionlint setup/network andnpm auditendpoint errors) and could not be completed here.Codex Task